syntax role modifiers

[jurgenvinju]

This PR implements syntax role modifiers.

SyntaxModifiers.pdf

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 28.35821% with 432 lines in your changes are missing coverage. Please review.

Project coverage is 49%. Comparing base (ab243ce) to head (d6ed722).

Files	Patch %	Lines
src/org/rascalmpl/types/ModifySyntaxRole.java	23%	208 Missing and 27 partials :warning:
src/org/rascalmpl/ast/SyntaxRoleModifier.java	20%	90 Missing and 1 partial :warning:
src/org/rascalmpl/library/Type.java	35%	24 Missing :warning:
src/org/rascalmpl/ast/Type.java	34%	20 Missing and 1 partial :warning:
src/org/rascalmpl/types/RascalTypeFactory.java	43%	12 Missing and 1 partial :warning:
...org/rascalmpl/values/parsetrees/SymbolFactory.java	35%	10 Missing and 1 partial :warning:
src/org/rascalmpl/ast/ShellCommand.java	0%	7 Missing :warning:
src/org/rascalmpl/ast/NullASTVisitor.java	0%	6 Missing :warning:
src/org/rascalmpl/types/RascalType.java	0%	6 Missing :warning:
src/org/rascalmpl/types/TypeReifier.java	0%	4 Missing :warning:
... and 9 more

Additional details and impacted files

@@           Coverage Diff            @@
##              main   #1835    +/-   ##
========================================
- Coverage       49%     49%    -1%     
- Complexity    6226    6266    +40     
========================================
  Files          662     665     +3     
  Lines        59419   60050   +631     
  Branches      8613    8726   +113     
========================================
+ Hits         29236   29474   +238     
- Misses       27996   28357   +361     
- Partials      2187    2219    +32     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[DavyLandman]

I'll start reviewing this soon. or are you still writing it @jurgenvinju ?

[DavyLandman]

Impressive, if you ignore the generated code, it's actually quite compact.

[jurgenvinju]

I'll start reviewing this soon. or are you still writing it @jurgenvinju ?

The util::Explode code is actually more of a integration test; the rest should be almost done. Because of bootstrapping issues, where the standard library needs to be type-checking correctly, before we can release the new code, I think I have to park that use of the new feature until after we have extended the type-checker.

IOW: I'll merge this without util::Explode for bootstrapping purposes. The next step is extending and releasing rascal-core with this feature if we think we are done here.