rascal icon indicating copy to clipboard operation
rascal copied to clipboard

Published 20 hours ago • verified publisher icon usethesource

Fixing issue 916 on URI path interpolation

Open jurgenvinju opened this issue 2 years ago • 2 comments

  • removes deprecated calls and fixes modules names in tests
  • fixes #916
  • added tests for #916

jurgenvinju avatar Jun 01 '23 12:06 jurgenvinju

This one was open since 2015, but now more and more people get confused by it. It's probably because of the increased usage of clair which has path interpolation in its source code. Seems like a good time as any to fix it. At least we have some tests for it now.

jurgenvinju avatar Jun 01 '23 12:06 jurgenvinju

The current solution is broken. Another test for toLocation shows that the current way of interpolating path strings also introduces an extra / even if the interpolation is in the authority part of a URI.

  • [ ] Have to figure out a way to see if we are already in the path part somehow during the interpolation process.
  • [ ] Have to make sure we encode differently in the authority part then in the path part.

jurgenvinju avatar Jun 01 '23 14:06 jurgenvinju