rascal icon indicating copy to clipboard operation
rascal copied to clipboard

Rework maven code for faster calculation of path config

Open DavyLandman opened this issue 3 years ago • 2 comments

This needs effort to make this work together with our shaded jars.

DavyLandman avatar Oct 03 '22 15:10 DavyLandman

Codecov Report

Attention: Patch coverage is 69.04762% with 13 lines in your changes missing coverage. Please review.

Project coverage is 49%. Comparing base (5b9e319) to head (c82fbc9). Report is 35 commits behind head on main.

Files with missing lines Patch % Lines
src/org/rascalmpl/library/util/PathConfig.java 38% 8 Missing :warning:
src/org/rascalmpl/library/util/Maven.java 82% 3 Missing and 2 partials :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##              main   #1661   +/-   ##
=======================================
- Coverage       49%     49%   -1%     
- Complexity    6311    6312    +1     
=======================================
  Files          665     666    +1     
  Lines        59616   59616           
  Branches      8649    8649           
=======================================
- Hits         29502   29500    -2     
  Misses       27895   27895           
- Partials      2219    2221    +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 03 '22 16:10 codecov[bot]

The idea would be to turn this PR into a general utility/service for Maven-related features for Rascal:

  • dependency resolution
  • exploration and install of new components in the REPL/IDE

Davy's setup allows for a lean and fast application of maven features.

jurgenvinju avatar Oct 04 '22 14:10 jurgenvinju