Xidorn Quan

Results 258 comments of Xidorn Quan

If tagging is added, it would be great if [smart playlist](https://github.com/navidrome/navidrome/issues/1417) can also support tags.

Not sure whether it needs a patch, minor, or major version up.

It seems toml 0.4.x doesn't include any features, so I remove the `default-features = false` as well.

@est31 For Servo, I pretty much believe you want to open another PR which only upgrades error-chain, because the new version of toml requires serde 1.0, and for having that,...

If you can upgrade all of Servo dependencies to serde 1.0... that would be great as well :)

So Servo has finished upgrading its dependencies to Serde, and I think this becomes a blocker for us to upgrade toml crate. I do understand and appreciate the effort to...

We have whitelist to allow duplicate crates, but those are general for small and widely-used crates, so I don't think toml would fit in that category. Actually it makes me...

@nox I think the issue is that @joshtriplett doesn't want to introduce more dependencies for this low-level crate, and that probably makes sense. I guess it is probably better to...

@joshtriplett There is currently no critical reason for me to use the new version of toml (which is currently used by style crate's build script), but I'm not sure whether...

I tried this before, but it quickly becomes annoying when you see every code repeated twice wasting lots of screen space especially on mobile. I'm actually thinking about another direction:...