merge-gatekeeper icon indicating copy to clipboard operation
merge-gatekeeper copied to clipboard

Multiple jobs with the same name are treated as one job.

Open krukowskid opened this issue 2 years ago • 3 comments

Hi there, I am using reusable workflows and most of the workflows trigger the same set of jobs like

  - build-and-test / build
  - build-and-test / terraform-plan (prd, xwrd)
  - build-and-test / terraform-plan (dev, xwrd)
  - check-prstats / stats

It turns out that merge-gatekeeper v1.2.0 treats jobs with a common name as one job, and if one workflow succeeds while others are still running, it returns success. If any workflow fail before the first success then it returns failure

image

krukowskid avatar Jan 19 '23 16:01 krukowskid

Hi @krukowskid - thanks for raising the issue! ☺️

We haven't been using reusable workflows internally, but this is certainly something we need to fix. We will check more into this and get a patch release out as soon as we can 🙏

rytswd avatar Jan 23 '23 01:01 rytswd

We recently ran into this issue as well since we decided to use reusable workflows and composite actions.

But otherwise thank you for this awesome project. We recently migrated some Monorepos from GitLab and we were shocked to find out GitHub doesn't have this functionality built in.

mmellison avatar Apr 28 '23 03:04 mmellison