thrill icon indicating copy to clipboard operation
thrill copied to clipboard

Thrill reports all tests passing even if no browsers are connected for testing

Open plumlee opened this issue 12 years ago • 2 comments
trafficstars

Not a bug perhaps, but this would make use of thrill much clearer. A message indicating that no tests were run would be more helpful.

Steps to reproduce:

  • Run queen with defaults locally
  • Run thrill with defaults, pointing to a test file that has a test set to always fail.
  • Do NOT have any browsers connected to queen (i.e., don't have any browsers connecting to localhost:9000)

Thrill will report 'PASSED on all browsers'.

What would be preferred is that either queen or thrill indicate that no browsers are connected, rather than pass back a success message.

plumlee avatar Jun 17 '13 15:06 plumlee

Ah, yes, this is an issue. This should be a configurable option on whether the testing should succeed or fail if the tests can't be run due to unavailable browsers. This is also related to another (currently untracked) issue of requiring certain browsers to exist in the testing pool in order for testing to be considered a success. Unfortunately I'm on vacation until July, so I won't be able to fix it until then, but I'd be happy to accept a pull request.

unsetbit avatar Jun 17 '13 15:06 unsetbit

Will do, thx. Very nice tool, though, thank you. About to file a queen issue as well related to documentation.

plumlee avatar Jun 17 '13 15:06 plumlee