uno
uno copied to clipboard
fix(GridView): 1st item fails to render
GitHub Issue (If applicable): closes #16441
PR Type
What kind of change does this PR introduce?
- Bugfix
What is the current behavior?
GridView would fail to render 1st item in the collection.
What is the new behavior?
^ no more.
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
- [ ] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Validated PR
Screenshots Compare Test Runresults. - [x] Contains NO breaking changes
- [x] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
- [x] Commits must be following the Conventional Commits specification.
Other information
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16564/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16564/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16564/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16564/index.html
The build 123981 found UI Test snapshots differences: android-28-net7: 21, android-28-net7-Snap: 52, ios: 230, ios-Snap: 22, skia-gtk-screenshots: 26, skia-linux-screenshots: 56, skia-windows-screenshots: 24, wasm: 68, wasm-automated-net7.0-UWP-Default-automated: 24, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0
Details
-
android-28-net7: 21 changed over 829🚨🚨 Comparison Details (first 20) 🚨🚨
CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitleDecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageDetereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25FocusManager_FocusDirection_Left_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirectionListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsSelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPageSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageUpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageUpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageWhen_Forever_Storyboard_UITests_Shared_Windows_UI_Xaml_VisualStateTests_VisualState_Forever_EventsWhen_Testing_ComplexSetters_UITests_Shared_Windows_UI_Xaml_VisualStateTests_VisualState_ComplexSetters_AutomatedProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220Flyout_Namescope_UITests_Shared_Windows_UI_Xaml_Controls_FlyoutTests_Flyout_NamescopeProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220When_BitmapIcon_Generic_ChangedWhen_InListView_after_scrollWhen_InScrollViewer_after_scrollWhen_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
-
android-28-net7-Snap: 52 changed over 1064🚨🚨 Comparison Details (first 20) 🚨🚨
Keyboard_Keyboard_Showing_Dismissal_UITests_Shared_Windows_UI_Xaml_Input_Keyboard_Keyboard_Showing_DismissalKeyboard_UITests_Windows_UI_Xaml_Input_Keyboard_Keyboard_Events_UITests_Windows_UI_Xaml_Input_Keyboard_Keyboard_EventsListView_HorizontalListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGroupedPath_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LinearGradientBrush_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LinearGradientBrushImage_LoadFromBytes_Uno_UI_Samples_UITests_ImageTestsControl_LoadFromBytesListView_ListViewIncrementalLoading_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewIncrementalLoadingPointers_UITests_Windows_UI_Input_PointersTests_HitTest_LightDismiss_UITests_Windows_UI_Input_PointersTests_HitTest_LightDismissTeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPageGesture_Recognizer_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_RightTappedTests_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_RightTappedTestsPointers_UITests_Windows_UI_Input_PointersTests_HitTest_Control_UITests_Windows_UI_Input_PointersTests_HitTest_ControlPointers_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroupPointers_UITests_Windows_UI_Input_PointersTests_HitTest_Image_UITests_Windows_UI_Input_PointersTests_HitTest_ImageScrolling_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Add_Remove_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Add_RemoveImage_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStreamMUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageBreadcrumbBar_MUXControlsTestApp_BreadcrumbBarPage_MUXControlsTestApp_BreadcrumbBarPageListView_ListViewChangeView_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewChangeViewMediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_FillDefault_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelectedMediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
-
ios: 230 changed over 271🚨🚨 Comparison Details (first 20) 🚨🚨
Button_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Button_IsEnabled_AutomatedCheckBox_IsEnabled_StatePreservation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_AutomatedComboBoxTests_Fullscreen_Popup_iOS_ClosedContentPresenter_Changing_ContentTemplate_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Changing_ContentTemplateFlyoutTest_When_NoOverlayInputPassThroughElement_Then_DontPassThrough_woAuto_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElementFocusManager_FocusDirection_Up_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirectionImage_Invalid_image_invalid_after_hideItemsControl_AppendItem_UITests_Windows_UI_Xaml_Controls_ItemsControl_ItemsControl_AppendItemKeyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBoxScreenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-0Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-0Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-1Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-1ScrollViewer_Margin_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_MarginTextBox_RoundedCorners_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_RoundedCornersSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageTextBox_Selection_IsReadOnly_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_SelectionStaticResource_Converter_Validation_UITests_Shared_Resources_StaticResource_StaticResource_SimpleWhen_Foreground_Changed_With_Visibility_Before_-_blackTextBox_TextAlignment_Center_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_TextAlignment
-
ios-Snap: 22 changed over 1055🚨🚨 Comparison Details (first 20) 🚨🚨
Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_HorizontalImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_VerticalMediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_FillDefault_Uno_UI_Samples_UITests_Image_Image_UseTargetSize_Uno_UI_Samples_UITests_Image_Image_UseTargetSizeImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_WiderBrushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInListImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControlImage_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_FormatsSwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretchClipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_ScrollableBrushes_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelay_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelayDefault_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigationWebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_ExecuteScriptAsync_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_ExecuteScriptAsyncWebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationPropertiesWebView_UITests_Microsoft_UI_Xaml_Controls_WebViewTests_WebView_InvokeScriptAsync_UITests_Microsoft_UI_Xaml_Controls_WebViewTests_WebView_InvokeScriptAsyncButtons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplateWebView_WebView_ChromeClient_Uno_UI_Samples_Content_UITests_WebView_WebView_ChromeClientWebView_WebView_Mailto_Uno_UI_Samples_Content_UITests_WebView_WebView_MailtoListView_ListViewGrouped_ItemContainerStyleSelector_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGrouped_ItemContainerStyleSelector
-
skia-gtk-screenshots: 26 changed over 2196🚨🚨 Comparison Details (first 20) 🚨🚨
Ellipse.pngUsing .avi.png-darkUsing .avi.pngPasswordBox_AutoFill.png-darkPasswordBox_AutoFill.pngUIElement_ContextFlyout.png-darkUIElement_ContextFlyout.pngWindow_SetBackground.pngEllipse.png-darkRectangle.png-darkRectangle.pngMini player.png-darkMini player.pngBorderImageBrush.png-darkBorderImageBrush.pngWinUIColorPickerPage.png-darkWinUIColorPickerPage.pngImageInStackPanel.png-darkImageInStackPanel.pngPanelImageBrush.png
-
skia-linux-screenshots: 56 changed over 2196🚨🚨 Comparison Details (first 20) 🚨🚨
BorderImageBrushRelativeTransform.pngDoubleImageBrushInList.png-darkDoubleImageBrushInList.pngBorderImageBrush.png-darkBorderImageBrush.pngBorderImageBrushRelativeTransform.png-darkImageBrushStretch2.png-darkImageBrushStretch2.pngImageBrushInList.png-darkImageBrushInList.pngImageInStackPanel.png-darkImageInStackPanel.pngImage_UseTargetSize.png-darkImage_UseTargetSize.pngImageBrush_UniformToFill.png-darkImageBrush_UniformToFill.pngLargeImageList.png-darkLargeImageList.pngImageBrush_SameWithDelay.png-darkImageBrush_SameWithDelay.png
-
skia-windows-screenshots: 24 changed over 2196🚨🚨 Comparison Details (first 20) 🚨🚨
Ellipse.png-darkEllipse.pngImageInStackPanel.png-darkImageInStackPanel.pngImage_Stretch_None.png-darkImage_Stretch_None.pngImage_Stretch_None_ScrollViewer.png-darkImage_Stretch_None_ScrollViewer.pngImagesInlineInFlipView.png-darkImagesInlineInFlipView.pngStretchNoneBoundingBoxInDoubleStackPanel.png-darkStretchNoneBoundingBoxInDoubleStackPanel.pngRectangle.png-darkRectangle.pngUniformAlignmentCenterInDoubleStackPanelWebUri.png-darkUniformAlignmentCenterInDoubleStackPanelWebUri.pngNative.png-darkNative.pngUniform100x100.png-darkUniform100x100.png
-
wasm: 68 changed over 1046🚨🚨 Comparison Details (first 20) 🚨🚨
GenericApp.Views.Content.UITests.Animations.DoubleAnimation_RenderTransformOriginSamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewLegacySamplesApp.Windows_UI_Xaml_Controls.ListView.UndefinedHeightListViewUITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mkv_ExtensionUITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mov_ExtensionUITests.Windows_UI_ViewManagement.ApplicationViewSizingMUXControlsTestApp.NavigationViewRS3PageUITests.Microsoft_UI_Xaml_Controls.RefreshContainerTests.RefreshContainerHorizontalScrollUITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_DropDownPlacementUITests.Windows_ApplicationModel.Contacts.PickContactUno.UI.Samples.Content.UITests.CommandBar.CommandBar_NativeUITests.Shared.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_TopNavigationUITests.Shared.Windows_UI_Xaml_Input.Keyboard.Keyboard_Showing_DismissalGenericApp.Views.Content.UITests.Animations.DoubleAnimationUsingKeyFrames_TranslateXGenericApp.Views.Content.UITests.Animations.DoubleAnimation_TranslateXSamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_BasicNavigationUITests.Microsoft_UI_Xaml_Controls.TabViewTests.TabViewPageUITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Alignment_SizeOnControlUITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_Aligned_LeftUITests.Windows_UI_Xaml_Controls.ListView.ListView_Selection_Events
-
wasm-automated-net7.0-UWP-Default-automated: 24 changed over 1963🚨🚨 Comparison Details (first 20) 🚨🚨
MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_SourcesBrushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrushImage_Image_Stretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_NoneListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsDefault_StrokeThickness_MyPolygonListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPageMediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_ExtensionMediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_ExtensionDefault_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelectedWhen_Padding_Is_Changed_Then_Cache_Is_Missed_UITests_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_MeasureCacheWhen_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersTextBlock_TextBlock_LineHeight_TextTrimming_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_LineHeight_TextTrimmingTextBlock_TextBlock_Progressing_Trim_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Progressing_TrimTextBlock_TextBlock_Run_Inheritance_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Run_InheritancePath_StrokeThickness10FixedWidth_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_StrokeThickness10FixedWidthSequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageTestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_FeaturesWhen_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
-
wasm-automated-net7.0-UWP-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net7.0-UWP-RuntimeTests-1: 0 changed over 1 -
wasm-automated-net7.0-UWP-RuntimeTests-2: 0 changed over 1 -
wasm-automated-net7.0-WinUI-Benchmarks-automated: 0 changed over 1 -
wasm-automated-net7.0-WinUI-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net7.0-WinUI-RuntimeTests-1: 0 changed over 1 -
wasm-automated-net7.0-WinUI-RuntimeTests-2: 0 changed over 1