uno icon indicating copy to clipboard operation
uno copied to clipboard

fix(GridView): 1st item fails to render

Open Xiaoy312 opened this issue 1 year ago • 2 comments

GitHub Issue (If applicable): closes #16441

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

GridView would fail to render 1st item in the collection.

What is the new behavior?

^ no more.

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Xiaoy312 avatar May 02 '24 20:05 Xiaoy312

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16564/index.html

unodevops avatar May 02 '24 22:05 unodevops

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16564/index.html

unodevops avatar May 02 '24 23:05 unodevops

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16564/index.html

unodevops avatar May 06 '24 15:05 unodevops

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16564/index.html

unodevops avatar May 06 '24 16:05 unodevops

The build 123981 found UI Test snapshots differences: android-28-net7: 21, android-28-net7-Snap: 52, ios: 230, ios-Snap: 22, skia-gtk-screenshots: 26, skia-linux-screenshots: 56, skia-windows-screenshots: 24, wasm: 68, wasm-automated-net7.0-UWP-Default-automated: 24, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0

Details
  • android-28-net7: 21 changed over 829

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitle
    • DecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • Detereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75
    • Detereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50
    • Detereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25
    • FocusManager_FocusDirection_Left_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • SelectionTest_UITests_Microsoft_UI_Xaml_Controls_RadioButtonsTests_RadioButtonsPage
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • UpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • When_Forever_Storyboard_UITests_Shared_Windows_UI_Xaml_VisualStateTests_VisualState_Forever_Events
    • When_Testing_ComplexSetters_UITests_Shared_Windows_UI_Xaml_VisualStateTests_VisualState_ComplexSetters_Automated
    • ProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • Flyout_Namescope_UITests_Shared_Windows_UI_Xaml_Controls_FlyoutTests_Flyout_Namescope
    • ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
    • When_BitmapIcon_Generic_Changed
    • When_InListView_after_scroll
    • When_InScrollViewer_after_scroll
    • When_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewer
  • android-28-net7-Snap: 52 changed over 1064

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Keyboard_Keyboard_Showing_Dismissal_UITests_Shared_Windows_UI_Xaml_Input_Keyboard_Keyboard_Showing_Dismissal
    • Keyboard_UITests_Windows_UI_Xaml_Input_Keyboard_Keyboard_Events_UITests_Windows_UI_Xaml_Input_Keyboard_Keyboard_Events
    • ListView_HorizontalListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGrouped
    • Path_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LinearGradientBrush_UITests_Shared_Windows_UI_Xaml_Shapes_PathTestsControl_Path_LinearGradientBrush
    • Image_LoadFromBytes_Uno_UI_Samples_UITests_ImageTestsControl_LoadFromBytes
    • ListView_ListViewIncrementalLoading_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewIncrementalLoading
    • Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_LightDismiss_UITests_Windows_UI_Input_PointersTests_HitTest_LightDismiss
    • TeachingTip_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage_UITests_Microsoft_UI_Xaml_Controls_TeachingTipTests_TeachingTipPage
    • Gesture_Recognizer_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_RightTappedTests_UITests_Shared_Windows_UI_Input_GestureRecognizerTests_RightTappedTests
    • Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_Control_UITests_Windows_UI_Input_PointersTests_HitTest_Control
    • Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup
    • Pointers_UITests_Windows_UI_Input_PointersTests_HitTest_Image_UITests_Windows_UI_Input_PointersTests_HitTest_Image
    • Scrolling_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Add_Remove_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Add_Remove
    • Image_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStream
    • MUX_NumberBox_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPage
    • BreadcrumbBar_MUXControlsTestApp_BreadcrumbBarPage_MUXControlsTestApp_BreadcrumbBarPage
    • ListView_ListViewChangeView_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewChangeView
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
  • ios: 230 changed over 271

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Button_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Button_IsEnabled_Automated
    • CheckBox_IsEnabled_StatePreservation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_Automated
    • ComboBoxTests_Fullscreen_Popup_iOS_Closed
    • ContentPresenter_Changing_ContentTemplate_Uno_UI_Samples_Content_UITests_ContentPresenter_ContentPresenter_Changing_ContentTemplate
    • FlyoutTest_When_NoOverlayInputPassThroughElement_Then_DontPassThrough_woAuto_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElement
    • FocusManager_FocusDirection_Up_Validation_Uno_UI_Samples_Content_UITests_FocusTests_FocusManager_FocusDirection
    • Image_Invalid_image_invalid_after_hide
    • ItemsControl_AppendItem_UITests_Windows_UI_Xaml_Controls_ItemsControl_ItemsControl_AppendItem
    • Keyboard_Textbox_NoScrollViewer_Validation_0_-_Remove_Focus_on_normalTextBox
    • Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-0
    • Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-0
    • Screenshots_Image_Stretch_Algmnt_Inf_Horizontal_Mode-1
    • Screenshots_Image_Stretch_Alignment_SizeOnControl_Mode-1
    • ScrollViewer_Margin_UITests_Windows_UI_Xaml_Controls_ScrollViewerTests_ScrollViewer_Margin
    • TextBox_RoundedCorners_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_RoundedCorners
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TextBox_Selection_IsReadOnly_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_Selection
    • StaticResource_Converter_Validation_UITests_Shared_Resources_StaticResource_StaticResource_Simple
    • When_Foreground_Changed_With_Visibility_Before_-_black
    • TextBox_TextAlignment_Center_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_TextBox_TextAlignment
  • ios-Snap: 22 changed over 1055

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical
    • MediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_Fill
    • Default_Uno_UI_Samples_UITests_Image_Image_UseTargetSize_Uno_UI_Samples_UITests_Image_Image_UseTargetSize
    • Image_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Wider
    • Brushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList
    • Image_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl
    • Image_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
    • SwipeControl_MUXControlsTestApp_SwipeControlPage2_MUXControlsTestApp_SwipeControlPage2
    • Brushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretch
    • Clipping_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable_SamplesApp_Windows_UI_Xaml_Clipping_XamlButtonWithClipping_Scrollable
    • Brushes_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelay_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelay
    • Default_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation
    • WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_ExecuteScriptAsync_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_ExecuteScriptAsync
    • WebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties
    • WebView_UITests_Microsoft_UI_Xaml_Controls_WebViewTests_WebView_InvokeScriptAsync_UITests_Microsoft_UI_Xaml_Controls_WebViewTests_WebView_InvokeScriptAsync
    • Buttons_Custom_Button_With_ContentTemplate_Uno_UI_Samples_Content_UITests_ButtonTestsControl_Custom_Button_With_ContentTemplate
    • WebView_WebView_ChromeClient_Uno_UI_Samples_Content_UITests_WebView_WebView_ChromeClient
    • WebView_WebView_Mailto_Uno_UI_Samples_Content_UITests_WebView_WebView_Mailto
    • ListView_ListViewGrouped_ItemContainerStyleSelector_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewGrouped_ItemContainerStyleSelector
  • skia-gtk-screenshots: 26 changed over 2196

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Ellipse.png
    • Using .avi.png-dark
    • Using .avi.png
    • PasswordBox_AutoFill.png-dark
    • PasswordBox_AutoFill.png
    • UIElement_ContextFlyout.png-dark
    • UIElement_ContextFlyout.png
    • Window_SetBackground.png
    • Ellipse.png-dark
    • Rectangle.png-dark
    • Rectangle.png
    • Mini player.png-dark
    • Mini player.png
    • BorderImageBrush.png-dark
    • BorderImageBrush.png
    • WinUIColorPickerPage.png-dark
    • WinUIColorPickerPage.png
    • ImageInStackPanel.png-dark
    • ImageInStackPanel.png
    • PanelImageBrush.png
  • skia-linux-screenshots: 56 changed over 2196

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • BorderImageBrushRelativeTransform.png
    • DoubleImageBrushInList.png-dark
    • DoubleImageBrushInList.png
    • BorderImageBrush.png-dark
    • BorderImageBrush.png
    • BorderImageBrushRelativeTransform.png-dark
    • ImageBrushStretch2.png-dark
    • ImageBrushStretch2.png
    • ImageBrushInList.png-dark
    • ImageBrushInList.png
    • ImageInStackPanel.png-dark
    • ImageInStackPanel.png
    • Image_UseTargetSize.png-dark
    • Image_UseTargetSize.png
    • ImageBrush_UniformToFill.png-dark
    • ImageBrush_UniformToFill.png
    • LargeImageList.png-dark
    • LargeImageList.png
    • ImageBrush_SameWithDelay.png-dark
    • ImageBrush_SameWithDelay.png
  • skia-windows-screenshots: 24 changed over 2196

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • Ellipse.png-dark
    • Ellipse.png
    • ImageInStackPanel.png-dark
    • ImageInStackPanel.png
    • Image_Stretch_None.png-dark
    • Image_Stretch_None.png
    • Image_Stretch_None_ScrollViewer.png-dark
    • Image_Stretch_None_ScrollViewer.png
    • ImagesInlineInFlipView.png-dark
    • ImagesInlineInFlipView.png
    • StretchNoneBoundingBoxInDoubleStackPanel.png-dark
    • StretchNoneBoundingBoxInDoubleStackPanel.png
    • Rectangle.png-dark
    • Rectangle.png
    • UniformAlignmentCenterInDoubleStackPanelWebUri.png-dark
    • UniformAlignmentCenterInDoubleStackPanelWebUri.png
    • Native.png-dark
    • Native.png
    • Uniform100x100.png-dark
    • Uniform100x100.png
  • wasm: 68 changed over 1046

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • GenericApp.Views.Content.UITests.Animations.DoubleAnimation_RenderTransformOrigin
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewLegacy
    • SamplesApp.Windows_UI_Xaml_Controls.ListView.UndefinedHeightListView
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mkv_Extension
    • UITests.Shared.Windows_UI_Xaml_Controls.MediaPlayerElement.MediaPlayerElement_Mov_Extension
    • UITests.Windows_UI_ViewManagement.ApplicationViewSizing
    • MUXControlsTestApp.NavigationViewRS3Page
    • UITests.Microsoft_UI_Xaml_Controls.RefreshContainerTests.RefreshContainerHorizontalScroll
    • UITests.Shared.Windows_UI_Xaml_Controls.ComboBox.ComboBox_DropDownPlacement
    • UITests.Windows_ApplicationModel.Contacts.PickContact
    • Uno.UI.Samples.Content.UITests.CommandBar.CommandBar_Native
    • UITests.Shared.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_TopNavigation
    • UITests.Shared.Windows_UI_Xaml_Input.Keyboard.Keyboard_Showing_Dismissal
    • GenericApp.Views.Content.UITests.Animations.DoubleAnimationUsingKeyFrames_TranslateX
    • GenericApp.Views.Content.UITests.Animations.DoubleAnimation_TranslateX
    • SamplesApp.Samples.Windows_UI_Xaml_Controls.NavigationViewTests.NavigationView_BasicNavigation
    • UITests.Microsoft_UI_Xaml_Controls.TabViewTests.TabViewPage
    • UITests.Shared.Windows_UI_Xaml_Controls.ImageTests.Image_Stretch_Alignment_SizeOnControl
    • UITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_Aligned_Left
    • UITests.Windows_UI_Xaml_Controls.ListView.ListView_Selection_Events
  • wasm-automated-net7.0-UWP-Default-automated: 24 changed over 1963

    🚨🚨 Comparison Details (first 20) 🚨🚨
    • MediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Sources
    • Brushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrush
    • Image_Image_Stretch_None_Uno_UI_Samples_UITests_ImageTestsControl_Image_Stretch_None
    • ListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • Default_StrokeThickness_MyPolygon
    • ListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItems
    • ColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPage
    • MediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_Extension
    • MediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_Extension
    • Default_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected
    • When_Padding_Is_Changed_Then_Cache_Is_Missed_UITests_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_MeasureCache
    • When_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • TextBlock_TextBlock_LineHeight_TextTrimming_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_LineHeight_TextTrimming
    • TextBlock_TextBlock_Progressing_Trim_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Progressing_Trim
    • TextBlock_TextBlock_Run_Inheritance_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Run_Inheritance
    • Path_StrokeThickness10FixedWidth_SamplesApp_Windows_UI_Xaml_Shapes_PathTestsControl_StrokeThickness10FixedWidth
    • SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPage
    • TestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
    • When_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
    • When_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_Pointers
  • wasm-automated-net7.0-UWP-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-UWP-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net7.0-UWP-RuntimeTests-2: 0 changed over 1

  • wasm-automated-net7.0-WinUI-Benchmarks-automated: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-0: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-1: 0 changed over 1

  • wasm-automated-net7.0-WinUI-RuntimeTests-2: 0 changed over 1

nventive-devops avatar May 06 '24 22:05 nventive-devops