uno
uno copied to clipboard
fix(droid): ComboBox flyout scroll reset on arrange
GitHub Issue (If applicable): closes #16074
PR Type
What kind of change does this PR introduce?
- Bugfix
What is the current behavior?
On android, the scroll position of the ComboBox flyout would reset whenever an arrange was called.
What is the new behavior?
^ no more.
PR Checklist
Please check if your PR fulfills the following requirements:
- [ ] Docs have been added/updated which fit documentation template (for bug fixes / features)
- [x] Unit Tests and/or UI Tests for the changes have been added (for bug fixes / features) (if applicable)
- [ ] Validated PR
Screenshots Compare Test Runresults. - [x] Contains NO breaking changes
- [x] Associated with an issue (GitHub or internal) and uses the automatic close keywords.
- [x] Commits must be following the Conventional Commits specification.
Other information
This happens because we are sending two layout requests with different sizes, presumably android reset the scroll to on current items when the viewport changes.
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16545/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16545/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16545/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16545/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16545/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16545/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16545/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16545/index.html
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-16545/index.html
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-16545/index.html
The build 124001 found UI Test snapshots differences: android-28-net7: 18, android-28-net7-Snap: 58, ios: 115, ios-Snap: 22, skia-gtk-screenshots: 35, skia-linux-screenshots: 62, skia-windows-screenshots: 41, wasm: 71, wasm-automated-net7.0-UWP-Default-automated: 21, wasm-automated-net7.0-UWP-RuntimeTests-0: 0, wasm-automated-net7.0-UWP-RuntimeTests-1: 0, wasm-automated-net7.0-UWP-RuntimeTests-2: 0, wasm-automated-net7.0-WinUI-Benchmarks-automated: 0, wasm-automated-net7.0-WinUI-RuntimeTests-0: 0, wasm-automated-net7.0-WinUI-RuntimeTests-1: 0, wasm-automated-net7.0-WinUI-RuntimeTests-2: 0
Details
-
android-28-net7: 18 changed over 829🚨🚨 Comparison Details (first 20) 🚨🚨
CommandBar_LongTitle_Validation_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_LongTitleDecimalFormatterTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageWhen_BitmapIcon_Generic_ChangedWebView_NavigateToLongString_AfterSuccessWhen_Parent_PointerMoved_After_drag_on_non-scrolling_ScrollViewerWhen_Parent_PointerMoved_After_drag_on_ScrollViewer_-_touchDetereminate_ProgressRing_Validation75_[#FF0000_#008000_#008000_#008000]_Progress-Ring-Value-75NativeCommandBar_Size_Uno_UI_Samples_Content_UITests_CommandBar_CommandBar_DynamicWhen_InListView_after_scrollDetereminate_ProgressRing_Validation50_[#FF0000_#008000_#008000_#FF0000]_Progress-Ring-Value-50SequentialAnimations_SamplesApp_Windows_UI_Xaml_Media_Animation_SequentialAnimationsPageDetereminate_ProgressRing_Validation25_[#FF0000_#008000_#FF0000_#FF0000]_Progress-Ring-Value-25ProgressRing_IsEnabled_Running_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220UpDownEnabledTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageUpDownTest_UITests_Shared_Microsoft_UI_Xaml_Controls_NumberBoxTests_NumberBoxPageWhen_Tap_PressedReleasedAreHandled_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_PointersListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsProgressRing_Visibility_Collapsed_UITests_Windows_UI_Xaml_Controls_ProgressRing_WindowsProgressRing_GH1220
-
android-28-net7-Snap: 58 changed over 1064🚨🚨 Comparison Details (first 20) 🚨🚨
Gesture_Recognizer_Pointer_Events_test_bench_UITests_Shared_Windows_UI_Input_GestureRecognizer_PointersEventsImage_ImageSourceStream_Uno_UI_Samples_UITests_ImageTestsControl_ImageSourceStreamImage_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_Icons_UITests_Windows_UI_Xaml_Controls_ImageTests_SvgImageSource_IconsIcons_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_Foreground_UITests_Shared_Windows_UI_Xaml_Controls_BitmapIconTests_BitmapIcon_ForegroundListView_HorizontalListViewGrouped_SamplesApp_Windows_UI_Xaml_Controls_ListView_HorizontalListViewGroupedPointers_UITests_Windows_UI_Input_PointersTests_HitTest_LightDismiss_UITests_Windows_UI_Input_PointersTests_HitTest_LightDismissListView_ListViewScrollIntoViewSnapPoints_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewScrollIntoViewSnapPointsListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsMediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_FillMediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_MinimalMediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_SourcesPointers_UITests_Windows_UI_Input_PointersTests_HitTest_Control_UITests_Windows_UI_Input_PointersTests_HitTest_ControlPointers_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroup_UITests_Windows_UI_Input_PointersTests_HitTest_GeometryGroupPointers_UITests_Windows_UI_Input_PointersTests_HitTest_Image_UITests_Windows_UI_Input_PointersTests_HitTest_ImageGridView_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTest_Uno_UI_Samples_Content_UITests_GridView_GridViewScrollIntoViewTestMediaPlayerElement_Using_mov_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mov_ExtensionMediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_ExtensionMediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_ExtensionScrolling_MUXControlsTestApp_ScrollViewWithScrollControllersPage_MUXControlsTestApp_ScrollViewWithScrollControllersPageTextBlock_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout_UITests_Shared_Windows_UI_Xaml_Controls_TextBlockControl_TextBlock_Layout
-
ios: 115 changed over 271🚨🚨 Comparison Details (first 20) 🚨🚨
Button_NestedButtons_Validation_nVentive_Umbrella_Views_UI_Samples_Content_UITests_ButtonTestsControl_Nested_ButtonsCheck_ListView_Swallows_Measure_after_scrollContentControl_Changing_ContentTemplate_Uno_UI_Samples_Content_UITests_ContentControlTestsControl_ContentControl_Changing_ContentTemplateKeyboard_Textbox_NoScrollViewer_Validation_Uno_UI_Samples_Content_UITests_TextBoxControl_Input_Test_NoScrollViewer_AutomatedToggleSwitch_IsEnabled_Validation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_ToggleSwitch_IsEnable_AutomatedTouch_Validation_0_-_button_inside_gridWhen_Navigated_CommandBarDisplayCustomBackButtonIcon_NativeFrame_Source_setCheckBox_DoubleTapValidation_Uno_UI_Samples_Content_UITests_ButtonTestsControl_CheckBox_IsEnabled_AutomatedButton_Events_UITests_Shared_Windows_UI_Xaml_Controls_Button_Button_EventsComboBoxTests_ToggleDisabled_ComboBox_EnabledCheck_CornerRadius_Border_UITests_Shared_Windows_UI_Xaml_Controls_BorderTests_Border_CornerRadius_ToggleComboBoxTests_Stretch_UITests_Windows_UI_Xaml_Controls_ComboBox_ComboBox_StretchFlyoutTest_When_OverlayInputPassThroughElement_Then_PassThrough_withOff_UITests_Shared_Windows_UI_Xaml_Controls_Flyout_Flyout_OverlayInputPassThroughElementKeyboard_Textbox_NoScrollViewer_Validation_4_-_Remove_Focus_on_multilineTextBoxNativeCommandBar_Automated_UITests_Windows_UI_Xaml_Controls_CommandBar_CommandBar_Native_With_ContentStaticResource_CSharp_Validation_UITests_Shared_Resources_StaticResource_StaticResource_SimpleThreeStates_IndeterminateStaticResource_XAML_Validation_UITests_Shared_Resources_StaticResource_StaticResource_SimpleThreeStates_UITests_Shared_Windows_UI_Xaml_Controls_CheckBoxTests_CheckBox_AutomatedTextBox_TextChanged_UITests_Shared_Windows_UI_Xaml_Controls_TextBoxTests_TextBox_TextChanged
-
ios-Snap: 22 changed over 1055🚨🚨 Comparison Details (first 20) 🚨🚨
ListView_ListViewStackPanel_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewStackPanelBrushes_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelay_UITests_Shared_Windows_UI_Xaml_Media_ImageBrushTests_ImageBrush_SameWithDelayBrushes_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransform_GenericApp_Views_Content_UITests_ImageBrushTestControl_BorderImageBrushRelativeTransformDefault_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigation_Uno_UI_Samples_Content_UITests_WebView_WebView_AnchorNavigationBrushes_ImageBrushStretch_Uno_UI_Samples_UITests_ImageBrushTestControl_ImageBrushStretchImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Horizontal_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_HorizontalImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_Vertical_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Algmnt_Inf_VerticalListView_ListView_With_ListViews_Count_Measure_UITests_Shared_Windows_UI_Xaml_Controls_ListView_ListView_With_ListViews_Count_MeasureColorPicker_WinUIColorPickerPage_UITests_Shared_Microsoft_UI_Xaml_Controls_ColorPickerTests_WinUIColorPickerPageGrid_CenteredGridinGridwiththreefixedsizechildren_Uno_UI_Samples_Content_UITests_GridTestsControl_CenteredGridinGridwiththreefixedsizechildrenBrushes_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInList_Uno_UI_Samples_Samples_Shared_Content_UITests_ImageBrushInListImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Taller_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_TallerListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsMediaPlayerElement_MediaPlayerElement_Stretch_Fill_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Stretch_FillMediaPlayerElement_Mini_player_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_MinimalImage_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_Bigger_Uno_UI_Samples_UITests_Image_Image_Stretch_Alignment_BiggerWebView_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationProperties_UITests_Microsoft_UI_Xaml_Controls_WebView2Tests_WebView2_NavigationPropertiesWebView_UITests_Microsoft_UI_Xaml_Controls_WebViewTests_WebView_InvokeScriptAsync_UITests_Microsoft_UI_Xaml_Controls_WebViewTests_WebView_InvokeScriptAsyncImage_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControl_UITests_Shared_Windows_UI_Xaml_Controls_ImageTests_Image_Stretch_Alignment_SizeOnControlImage_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats_UITests_Windows_UI_Xaml_Controls_ImageTests_Image_Formats
-
skia-gtk-screenshots: 35 changed over 2196🚨🚨 Comparison Details (first 20) 🚨🚨
Rectangle.png-darkRectangle.pngTransformToVisual_Transform.png-darkTransformToVisual_Transform.pngWindow_SetBackground.pngEllipse.png-darkImagesInlineInFlipView.pngUIElement_ContextFlyout.png-darkUIElement_ContextFlyout.pngDoubleImageBrushInList.png-darkDoubleImageBrushInList.pngEllipse.pngNative.png-darkNative.pngSvgImageSource_Icons.png-darkSvgImageSource_Icons.pngUsing .avi.png-darkUsing .avi.pngPasswordBox_AutoFill.png-darkPasswordBox_AutoFill.png
-
skia-linux-screenshots: 62 changed over 2196🚨🚨 Comparison Details (first 20) 🚨🚨
DoubleImageBrushInList.png-darkDoubleImageBrushInList.pngBorderImageBrush.pngBorderImageBrushRelativeTransform.png-darkImageBrushStretch2.png-darkImageBrushStretch2.pngImageBrush_SameWithDelay.png-darkImageBrush_SameWithDelay.pngImageBrush_StreamSource.png-darkImageBrush_StreamSource.pngBorderImageBrushRelativeTransform.pngImageInStackPanel.png-darkImageInStackPanel.pngImagesInlineInFlipView.png-darkImagesInlineInFlipView.pngImageWithLateSourceUniformToFill.png-darkImageWithLateSourceUniformToFill.pngBorderImageBrush.png-darkImageBrushInList.png-darkImageBrushInList.png
-
skia-windows-screenshots: 41 changed over 2196🚨🚨 Comparison Details (first 20) 🚨🚨
ImageSourceUrlMsAppDataScheme.png-darkImageSourceUrlMsAppDataScheme.pngImage_UseTargetSize.png-darkImage_UseTargetSize.pngBorderImageBrush.pngDoubleImageBrushInList.pngEllipsemaskingEllipseSuperpositionPanel.pngImageIconPage.png-darkImageIconPage.pngImageBrush_SameWithDelay.png-darkImageBrush_SameWithDelay.pngColorPickerSample.pngBorderImageBrush.png-darkPanelImageBrush.pngPathImageBrushfill.pngSwipeControlPage2.png-darkSwipeControlPage2.pngNative.png-darkNative.pngRectanglemaskingRectangleGrid.png
-
wasm: 71 changed over 1046🚨🚨 Comparison Details (first 20) 🚨🚨
GenericApp.Views.Content.UITests.Animations.DoubleAnimationUsingKeyFrames_TranslateXGenericApp.Views.Content.UITests.Animations.DoubleAnimation_TranslateXGenericApp.Views.Samples.Shared.Content.UITests.GridViewMultipleSelectionModeMUXControlsTestApp.PaneLayoutTestPageSamplesApp.Wasm.Windows_UI_Xaml_Controls.ListView.ListView_IsSelectedSamplesApp.Windows_UI_Xaml_Controls.ListView.ListViewWithinScollViewerSamplesApp.Windows_UI_Xaml_Controls.ListView.UndefinedHeightListViewUITests.Windows_ApplicationModel.Contacts.PickContactUITests.Windows_ApplicationModel.DataTransfer.DataTransferManagerTestsMUXControlsTestApp.NavigationViewItemTemplatePageUITests.Microsoft_UI_Xaml_Controls.NavigationViewTests.NavigationViewBasicPageUITests.Windows_UI_Xaml_Media_Animation.FadeInOutThemeAnimationPageUITests.Microsoft_UI_Xaml_Controls.ProgressBar.WinUIProgressBarSimpleUITests.Shared.Microsoft_UI_Xaml_Controls.ColorPickerTests.WinUIColorPickerPageUITests.Shared.Windows_UI_Xaml_Controls.ListView.ListView_DataTemplateSelectorUITests.Windows_UI_Xaml.DragAndDrop.DragDrop_ListView_Custom_StatesUITests.Windows_UI_Xaml_Controls.Repeater.StackLayout_SimpleUno.UI.Samples.Content.UITests.DoubleAnimationTestsControlMUXControlsTestApp.NavigationViewBlankPage1MUXControlsTestApp.RefreshVisualizerPage
-
wasm-automated-net7.0-UWP-Default-automated: 21 changed over 1963🚨🚨 Comparison Details (first 20) 🚨🚨
Default_StrokeThickness_MyPolygonListView_ListViewSelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsListView_SelectedItems_SamplesApp_Windows_UI_Xaml_Controls_ListView_ListViewSelectedItemsBrushes_Uno_UI_Samples_UITests_ImageBrushTestControl_Ellipse_Uno_UI_Samples_UITests_ImageBrushTestControl_EllipseDefault_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelected_SamplesApp_Wasm_Windows_UI_Xaml_Controls_ListView_ListView_IsSelectedMediaPlayerElement_Sources_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_SourcesPickers_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated_Reload_UITests_Shared_Windows_UI_Xaml_Controls_TimePicker_TimePicker_Flyout_Automated_ReloadBrushes_BorderImageBrush_Uno_UI_Samples_UITests_ImageBrushTestControl_BorderImageBrushDefault_StrokeThickness_MyLine_0_StrokeThicknessMediaPlayerElement_Using_mp3_Audio_only_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Mp3_ExtensionMediaPlayerElement_Using_ogg_UITests_Shared_Windows_UI_Xaml_Controls_MediaPlayerElement_MediaPlayerElement_Ogg_ExtensionWhen_MultipleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_SingleSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_SingleSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_NoSelectionWithItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersWhen_NoSelection_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersTextBlock_TextBlock_Progressing_Trim_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Progressing_TrimTextBlock_TextBlock_Run_Inheritance_Uno_UI_Samples_Content_UITests_TextBlockControl_TextBlock_Run_InheritanceWhen_ExtendedSelectionWithoutItemClick_Then_PointersEvents_UITests_Windows_UI_Xaml_Controls_ListView_ListView_Selection_PointersTestProgressRing_InitialState_UITests_Microsoft_UI_Xaml_Controls_ProgressRing_WinUIProgressRing_Features
-
wasm-automated-net7.0-UWP-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net7.0-UWP-RuntimeTests-1: 0 changed over 1 -
wasm-automated-net7.0-UWP-RuntimeTests-2: 0 changed over 1 -
wasm-automated-net7.0-WinUI-Benchmarks-automated: 0 changed over 1 -
wasm-automated-net7.0-WinUI-RuntimeTests-0: 0 changed over 1 -
wasm-automated-net7.0-WinUI-RuntimeTests-1: 0 changed over 1 -
wasm-automated-net7.0-WinUI-RuntimeTests-2: 0 changed over 1