Uno.Samples icon indicating copy to clipboard operation
Uno.Samples copied to clipboard

Published 20 hours ago • verified publisher icon unoplatform

Upgrade all samples to run with latest uno and latest VS 2022.

Open jeromelaban opened this issue 3 years ago • 9 comments

The last update in VS 2022 caused some samples to stop building, causing the canary to fail. The current non-canary CI is built around partial validation, which makes other samples miss validations.

Updating projects one by one to uno latest will force a rebuild with VS 2022, and will show which projects fail in an incremental manner.

Summary

PR #154 - To create the ArchiveProject folder and exclude projects from the CI build. PR #153 - WebRTC.Wasm - Updated Uno to the latest packages, after the project there is a runtime error to fix - ListViewSample - Already updated.

jeromelaban avatar Sep 14 '22 19:09 jeromelaban

@jeromelaban , the project that still falls on canary is TimeEntryRia, which uses .NET 4.0. Is it updated?

image

image

aesteves900 avatar Sep 16 '22 01:09 aesteves900

@aesteves900 try upgrading it to net48 and see if it helps.

jeromelaban avatar Sep 16 '22 11:09 jeromelaban

@jeromelaban , I tried with no success, because the project was created on Visual Studio 2010. I believe creating a fresh project and importing all objects is the only way. What do you recommend for the next steps?

image

aesteves900 avatar Sep 18 '22 20:09 aesteves900

@aesteves900 you should be able to create a net48 "sdk-style" project in place of the existing one.

jeromelaban avatar Sep 18 '22 21:09 jeromelaban

@jeromelaban , I saw a lot of compatibility issues when trying .NET 4.8 migration, because TimeEntryRia (canary CI issue) uses a bunch of legacy libraries like WCF Services, RIA Services, and SilverLight. I'm a little confused it's the best way I just try migrating or rewriting the sample. Definitely, my option is not just to install some NuGet packages and we will be good to go. I need some direction on the next steps. Can you give to me more details about the expected results from this task? I'm stuck at this point.

image

aesteves900 avatar Sep 20 '22 03:09 aesteves900

Interesting, support for silverlight has been removed completely, it seems that we'll need to take this sample out of support (moved to a "legacy" folder), as we're not able to build it anymore. Let's create a "Legacy" folder at the root, and move the sample there.

jeromelaban avatar Sep 20 '22 12:09 jeromelaban

@jeromelaban, There is one solution for each project. What is the correct way to disable the build for the new legacy folder?

aesteves900 avatar Sep 20 '22 13:09 aesteves900

Yes, like this image

image

Do just I need to create a folder on the repo and move obsolete projects there?

aesteves900 avatar Sep 20 '22 16:09 aesteves900

The Samples are automatically built through here: https://github.com/unoplatform/Uno.Samples/blob/4ed28638d14c83b76f31868c87733e06e312da9a/.vsts-ci.yml#L33

We'll need to add an exclusion when the path starts with Legacy

jeromelaban avatar Sep 21 '22 00:09 jeromelaban