undocs icon indicating copy to clipboard operation
undocs copied to clipboard

fix(steps): simplify logic

Open cpreston321 opened this issue 1 year ago โ€ข 1 comments

๐Ÿ”— Linked issue

#106

โ“ Type of change

  • [ ] ๐Ÿ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • [X] ๐Ÿž Bug fix (a non-breaking change that fixes an issue)
  • [ ] ๐Ÿ‘Œ Enhancement (improving an existing functionality like performance)
  • [ ] โœจ New feature (a non-breaking change that adds functionality)
  • [ ] ๐Ÿงน Chore (updates to the build process or auxiliary tools and libraries)
  • [ ] โš ๏ธ Breaking change (fix or feature that would cause existing functionality to change)

๐Ÿ“š Description

Resolves #106

In this PR, I make the component more generic so it can work for all cases.

๐Ÿ“ Checklist

  • [X] I have linked an issue or discussion.
  • [X] I have updated the documentation accordingly.

cpreston321 avatar Mar 29 '24 16:03 cpreston321

Deploying undocs with ย Cloudflare Pages ย Cloudflare Pages

Latest commit: 5e73926
Status:ย โœ…ย  Deploy successful!
Preview URL: https://9429231e.undocs.pages.dev
Branch Preview URL: https://fix-steps.undocs.pages.dev

View logs

@cpreston321 do you remember if there was any issues that PR was in draft state? (thinking to merge and try to see if there is any..)

pi0 avatar Sep 04 '24 17:09 pi0

Hey @pi0,

The last thing was to add code to support the comment you added, I think I was trying to solve for but the solution never got pushed: https://github.com/unjs/undocs/pull/112#discussion_r1544755644

cpreston321 avatar Sep 04 '24 17:09 cpreston321

i imagined you already pushed it ๐Ÿ˜… Do you think we should revert?

pi0 avatar Sep 04 '24 17:09 pi0

@pi0 i think the solution works better than it did previously but we can iterate to fix the issue that you made a comment on.

cpreston321 avatar Sep 04 '24 18:09 cpreston321