darts icon indicating copy to clipboard operation
darts copied to clipboard

Replacing the obsolete applymap with map

Open quant12345 opened this issue 1 year ago • 2 comments

DataFrame.applymap has been deprecated.

I'd like to do a PR to fix this. What does the community think?

Warning:

darts/tests/test_timeseries_multivariate.py::TestTimeSeries::test_map

  /darts/darts/tests/test_timeseries.py:1449: FutureWarning: DataFrame.applymap has been deprecated. Use DataFrame.map instead.
    df_0[["0"]] = df_0[["0"]].applymap(fn)

darts/tests/test_timeseries.py::TestTimeSeries::test_map
darts/tests/test_timeseries_multivariate.py::TestTimeSeries::test_map
  /darts/darts/tests/test_timeseries.py:1450: FutureWarning: DataFrame.applymap has been deprecated. Use DataFrame.map instead.
    df_2[["2"]] = df_2[["2"]].applymap(fn)

darts/tests/test_timeseries.py::TestTimeSeries::test_map
darts/tests/test_timeseries_multivariate.py::TestTimeSeries::test_map
  /darts/darts/tests/test_timeseries.py:1451: FutureWarning: DataFrame.applymap has been deprecated. Use DataFrame.map instead.
    df_01[["0", "1"]] = df_01[["0", "1"]].applymap(fn)

darts/tests/test_timeseries.py::TestTimeSeries::test_map
darts/tests/test_timeseries_multivariate.py::TestTimeSeries::test_map
  /darts/darts/tests/test_timeseries.py:1452: FutureWarning: DataFrame.applymap has been deprecated. Use DataFrame.map instead.
    df_012 = df_012.applymap(fn)

quant12345 avatar Jul 01 '24 13:07 quant12345

Hi @quant12345,

Sure, you can go ahead :)

madtoinou avatar Jul 01 '24 14:07 madtoinou

Hi @madtoinou, contribution says that need an issue first, so I asked)

quant12345 avatar Jul 01 '24 14:07 quant12345

Fixed in #2436

dennisbader avatar Jul 02 '24 07:07 dennisbader