unison icon indicating copy to clipboard operation
unison copied to clipboard

update `todo`

Open aryairani opened this issue 1 year ago • 7 comments

The updated command should

  • list name conflicts
  • list missing dependency names
    • bonus: provide hints if they are named in other project branches
  • list violated merge preconditions
  • list dependents of todo

aryairani avatar Jun 12 '24 21:06 aryairani

What's "list dependents of todo" – typo?

mitchellwrosen avatar Jun 12 '24 21:06 mitchellwrosen

@mitchellwrosen I think that refers to dependents of https://share.unison-lang.org/@unison/base/code/releases/3.7.0/latest/terms/todo

hojberg avatar Jun 14 '24 17:06 hojberg

Ah, yes, of course

mitchellwrosen avatar Jun 14 '24 17:06 mitchellwrosen

Re:

  • bonus: provide hints if they are named in other project branches

Not sure what we can reasonably accomplish here, but this is the motivation:

image

aryairani avatar Jun 24 '24 17:06 aryairani

Also, in the previous screenshot... what is ucm doing? It seems like if #dc5 appears in the list, that #t7r should too. But where's the dependent of #dc5? I guess I can use dependents to find out, but it would be better if todo told me why things were in the list.

image

aryairani avatar Jun 24 '24 17:06 aryairani

@aryairani It's currently just showing the unnamed things that are directly – not indirectly – referenced by your code

mitchellwrosen avatar Jun 24 '24 17:06 mitchellwrosen

@aryairani It's currently just showing the unnamed things that are directly – not indirectly – referenced by your code

Right, ok. We should consider at some point what other hints we could try to provide that would be helpful in choosing a name for it. Maybe that's dependent names, maybe it's names from other projects or Share, maybe it's something else.

And maybe transitive unnamed deps of from the direct unnamed deps, so that you're not getting one entry per time you todo

aryairani avatar Jun 24 '24 18:06 aryairani