unison icon indicating copy to clipboard operation
unison copied to clipboard

sanity check libs deduping

Open aryairani opened this issue 1 year ago • 1 comments

Deduping libs vs tiered name resolution strategy? Make sure that the copies that would be excluded would be the ones we don’t want to choose anyway.

aryairani avatar Jan 03 '24 21:01 aryairani

I looked into this; it we do to include all direct deps, and only avoid loading names of indirect deps that have already been loaded elsewhere.

However, the logic seems faulty: we just count lib segments anywhere in a name. So if you have a namespace outside lib, but with a lib segment somewhere (which should be allowed, no?), we might not load those names.

mitchellwrosen avatar Jan 04 '24 15:01 mitchellwrosen