pandera icon indicating copy to clipboard operation
pandera copied to clipboard

Update checks.py

Open jcadam14 opened this issue 1 year ago • 1 comments
trafficstars

Closes #1707

Fixed post-process to collect() on check results first before setting CheckResult references. Using the initial check_output lazyframe for check_output, check_passed, and failure_cases was causing pandera/backends/polars/base.py run_check calls to collect() for each of these references to call the check functions. So failures were causing the check functions to run three separate times.

jcadam14 avatar Jun 28 '24 18:06 jcadam14

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 82.59%. Comparing base (812b2a8) to head (38db3a2). Report is 150 commits behind head on main.

Files with missing lines Patch % Lines
pandera/backends/polars/checks.py 0.00% 3 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1719       +/-   ##
===========================================
- Coverage   94.28%   82.59%   -11.69%     
===========================================
  Files          91      117       +26     
  Lines        7013     8716     +1703     
===========================================
+ Hits         6612     7199      +587     
- Misses        401     1517     +1116     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 28 '24 19:06 codecov[bot]

thanks @jcadam14 and congrats on your first PR to pandera! 🚀

cosmicBboy avatar Jul 02 '24 18:07 cosmicBboy

thanks @jcadam14 and congrats on your first PR to pandera! 🚀

Glad to help!

jcadam14 avatar Jul 02 '24 20:07 jcadam14