pandera icon indicating copy to clipboard operation
pandera copied to clipboard

Add str_length built-in check for PySpark backend

Open marrov opened this issue 1 year ago • 4 comments

Adds a builtin-check for str_length for the pyspark.sql backend, solving these issues:

marrov avatar Jun 25 '24 13:06 marrov

Codecov Report

Attention: Patch coverage is 40.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 93.46%. Comparing base (812b2a8) to head (b002e70). Report is 234 commits behind head on main.

Files with missing lines Patch % Lines
pandera/backends/pyspark/builtin_checks.py 40.00% 9 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1709      +/-   ##
==========================================
- Coverage   94.28%   93.46%   -0.82%     
==========================================
  Files          91      117      +26     
  Lines        7013     8856    +1843     
==========================================
+ Hits         6612     8277    +1665     
- Misses        401      579     +178     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 25 '24 23:06 codecov[bot]

thanks @marrov ! please run pre-commit to fix linter errors: https://pandera.readthedocs.io/en/stable/CONTRIBUTING.html#set-up-pre-commit

cosmicBboy avatar Jun 26 '24 12:06 cosmicBboy

thanks @marrov ! please run pre-commit to fix linter errors: https://pandera.readthedocs.io/en/stable/CONTRIBUTING.html#set-up-pre-commit

Yes, sorry for that I added it too hastily. Should be fixed now @cosmicBboy.

marrov avatar Jun 27 '24 07:06 marrov

thanks @marrov ! sorry to extend this a little longer, but this check needs unit tests, which can live here: https://github.com/unionai-oss/pandera/blob/main/tests/pyspark/test_pyspark_check.py

cosmicBboy avatar Jun 27 '24 14:06 cosmicBboy