unicorn icon indicating copy to clipboard operation
unicorn copied to clipboard

Wrong type hint for reg_write in Python bindings

Open sledgeh4w opened this issue 3 years ago • 0 comments

I found a wrong type hint for reg_write method of Uc in Python bindings.

Wrong:

def reg_write(self, reg_id: Union[int, ARMCPRegValue, ARM64CPRegValue, X86MMRReg, X86FPReg], value: int):
    ...

Correct:

def reg_write(self, reg_id: int, value: Union[int, ARMCPRegValue, ARM64CPRegValue, X86MMRReg, X86FPReg]):
    ...

I want to submit a PR to fix it, but I noticed that you are refactoring the python bindings and maybe release it in the next version. So I doubt if this fix is necessary?

sledgeh4w avatar Sep 15 '22 08:09 sledgeh4w