.gitignore is too vague since #1584

[ikelos]

There was a change made in #1584 that changes bindings/rust/target/ to just target/ which then ignores anything under qemu/target. This isn't a folder that seems to change that often, but it might catch out developers that are working across the whole tree.

https://github.com/unicorn-engine/unicorn/blob/55b2950cac4098bacfff3bdb72b58380ee15212c/.gitignore#L55

This can either be fixed by returning the bindings/rust/ to the start of the rule, or by explicitly adding a !/qemu/target/ to the .gitignore file.

Please let me know if you need any additional information....

[aquynh]

please pull req

[bet4it]

Fixed in #1616

[ikelos]

Thanks @bet4it, that seems to resolve the issue, but I'm confused what's it now ignoring, there isn't a top level target and I don't believe one is created during compilation, so the line seems redundant?

[bet4it]

The file Cargo.toml locates in the top level directory so target should also be created there.

[ikelos]

Ok, I see what's going on now, thanks. 5:)

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 15 days.