laravel-paystack icon indicating copy to clipboard operation
laravel-paystack copied to clipboard

Rewrote the Project for better support and possibilities.

Open bosunski opened this issue 6 years ago β€’ 6 comments

I really like the simplicity of paystack and of course laravel and this package is a bridge between them. I found out I kept adding lots of changes to the package when I see fit so I decided to have a major rewrite for it. Maybe from there, it can open more possibility for it. Looking at it, this is a Major change in the project maybe it should be tagged v2.0 or something.

😁Let's go straight to the point!

Summary Of changes

  • Added Lumen Support
  • Added more tests, hence better code coverage
  • Code structure and architecture improvements
  • ALL PAYSTACK API is now covered thanks to xeviant/paystack package
  • Removed collection of data tightly coupled over Laravel Request class - meaning data can now be passed as array arguments
  • Switched to HTTPlug instead of Guzzle
  • Started work on Cache support
  • Decoupled package to include a Manager and a Factory
  • Improved Code Style
  • Disabled support for PHP 5.*
  • Add a trait to allow Request injection if you still want to pass data over laravel request.
  • Multi-connection Support for multi-tenant apps or in environments where you need to switch between Live and Test environments quickly.
  • Package Discovery now works swiftly
  • Ported old methods whilst maintaining Facade access for the meaning we still have Backward compatibility.
  • Now depends on xeviant/paystack package which provides it all of paystack.

Testing Instruction

To test this in a Laravel Project, while it's not merged, do this:

  • Add this to your composer.json
    "require": {
        "unicodeveloper/laravel-paystack": "dev-lp",
    },
    "repositories": [
        {
            "type": "vcs",
            "url": "http://github.com/bosunski/laravel-paystack"
        }
    ],
  • Then run:
$ composer update

It will install this PR and then you can run:

php artisan vendor:publish

In the prompt choose option for Unicodeveloper\Paystack\PaystackServiceProvider

And then you can continue normal configuration and test.

Dancer-Thank-You

bosunski avatar Feb 20 '19 22:02 bosunski

@unicodeveloper Awaiting Review.

bosunski avatar Feb 21 '19 18:02 bosunski

@bosunski As a maintainer of a popular package, I can tell you it's not likely this PR will get reviewed. It's time-consuming work with a lot of mental overhead, and my guess is @unicodeveloper doesn't make use of this package himself anymore. I suggest you message him and ask him to make you a maintainer, so you can have merge and release rights. Then you can do ahead to revamp and improve the package as you'd like.

shalvah avatar Feb 21 '19 18:02 shalvah

Thanks, @shalvah. I tried to DM on twitter though, its closed for now.

bosunski avatar Feb 21 '19 18:02 bosunski

Thanks for the PR @bosunski. This is a lot of changes πŸ˜„

I'd try to take a look at it over the weekend.

unicodeveloper avatar Feb 21 '19 18:02 unicodeveloper

@bosunski πŸ‘ Nice! Great stuff! Especially that easy swap between test and live mode. Tempted to use yours pending when Uncle P reviews and possibly merge.

aeadedoyin avatar Feb 22 '19 11:02 aeadedoyin

@unicodeveloper still waiting on you.

bosunski avatar Mar 05 '19 14:03 bosunski