icu4x
icu4x copied to clipboard
WASM demo: expose functions under `ICU4X` namespace in the global scope
This exposes the ICU4X module as ICU4X in the global scope of the WASM demo, allowing the classes to be used directly from the browser console.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments to provide feedback.
I stomped all over this in https://github.com/unicode-org/icu4x/pull/6682, but I still think this is useful to merge. It would be nice to get the syntax highlighting to work on all code examples, and to expose the library on globalThis.
I stomped all over this in https://github.com/unicode-org/icu4x/pull/6682, but I still think this is useful to merge. It would be nice to get the syntax highlighting to work on all code examples, and to expose the library on globalThis.
If anyone else picks this up before me, just make sure to expose on window.top as well as window (or globalThis.top as well as globalThis, which is the same thing). This is necessary because the docs render the demo within an iframe.
Redone on top of the new snippet logic (which I also added syntax highlighting for). Example/explainer at the top now just shows how to destructure from the module object, as a full example isn't really necessary now the snippets are available.