icu4x icon indicating copy to clipboard operation
icu4x copied to clipboard

Published 20 hours ago • verified publisher icon unicode-org

Implement `SignedFixedDecimal` and `UnsignedFixedDecimal`

Open younies opened this issue 1 year ago • 1 comments

Related Issues: https://github.com/unicode-org/icu4x/issues/5065

younies avatar Oct 10 '24 13:10 younies

Good start; try to stick with the names we discussed in the thread. FixedDecimal and Signed<FixedDecimal>

sffc avatar Oct 14 '24 22:10 sffc

@sffc, @robertbastian, and @Manishearth,

This PR still needs testing fixes, but it is currently buildable.

I’m submitting it for review to confirm if we agree on the design and approach before moving forward with the next steps.

younies avatar Oct 28 '24 14:10 younies

@sffc & @robertbastian , the testing is still failing. I would appreciate it if you could take a quick look to ensure the design aligns with what we discussed.

younies avatar Nov 04 '24 12:11 younies

I did a quick look at the errors and they look like regular coding / import / feature issues.

@robertbastian can you help?

sffc avatar Nov 05 '24 04:11 sffc