icu4x icon indicating copy to clipboard operation
icu4x copied to clipboard

Remove DynamicDataProvider and expand methods into ExportableProvider

Open sffc opened this issue 1 year ago • 1 comments

I'm pretty sure that we're not using DynamicDataProvider anywhere except in the bounds of ExportableProvider.

We should merge DynamicDataProvider and IterableDynamicDataProvider into ExportableProvider in 2.0.

sffc avatar May 08 '24 18:05 sffc

I see DynamicDataProvider as a core provider type, it's the equivalent to DataProvider where the key is only known at runtime. In fact, AnyProvider and BufferProvider should be instantiations of DynamicDataProvider for AnyMarker and BufferMarker.

robertbastian avatar May 21 '24 10:05 robertbastian

Also note the new trait BoundDataProvider which is similar to DynamicDataProvider but it is actually useful in components.

sffc avatar Jun 03 '24 17:06 sffc

DynamicDataProvider currently unifies code between BufferProvider aka DynamicDataProvider<BufferMarker>, and ExportableProvider, aka DynamicDataProvider<ExportMarker>. Ideally it would also do this for AnyMarker, but this doesn't currently work with yoke.

robertbastian avatar Jun 27 '24 12:06 robertbastian