icu4x icon indicating copy to clipboard operation
icu4x copied to clipboard

Re-export Time in icu::calendar?

Open sffc opened this issue 2 years ago • 3 comments

There is icu::calendar::Date and icu::calendar::DateTime but not icu::calendar::Time.

We do have a Time type but it is in icu::calendar::types::Time which is much less discoverable.

I think we should re-export Time.

CC @Manishearth

sffc avatar Nov 20 '23 19:11 sffc

I am weakly in favor of this.

Manishearth avatar Nov 20 '23 19:11 Manishearth

For me, Time is clearly in a higher tier than the other things in types like Hour, IsoYear, etc.

Two pieces of evidence:

  1. Temporal defines the following top level types, which includes Time:
    • PlainDate
    • PlainDateTime
    • PlainTime
    • ZonedDateTime
    • PlainMonthDay
    • PlainYearMonth
  2. We also have both a DateFormatter and a TimeFormatter.

sffc avatar Nov 21 '23 00:11 sffc

@zbraniecki Do you agree?

sffc avatar Nov 30 '23 17:11 sffc

sure!

zbraniecki avatar Mar 14 '24 16:03 zbraniecki