icu4x icon indicating copy to clipboard operation
icu4x copied to clipboard

Published 20 hours ago • verified publisher icon unicode-org

Consider running ignored / exhaustive tests on CI

Open sffc opened this issue 2 years ago • 2 comments
trafficstars

ICU4C has exhaustive tests. Rust has an equivalent called "ignored" tests, which use the #[ignore] annotation. We should consider running these tests on main CI. It would also be nice to run it on PRs, but only when code in the same component is being touched.

https://doc.rust-lang.org/book/ch11-02-running-tests.html#ignoring-some-tests-unless-specifically-requested

@sotam1069 is adding some tests like this for calendrical calculations.

sffc avatar Jul 24 '23 22:07 sffc

Discuss with:

  • @robertbastian
  • @sffc

Optional:

  • @zbraniecki

sffc avatar Oct 19 '23 17:10 sffc

Going forward, #[ignored] will be for slow tests, but they still have to pass. Daily CI will run them.

robertbastian avatar Jun 27 '24 13:06 robertbastian