Use extend() with iterator as appropriate in normalizer and collator

[hsivonen]

trafficstars

Instead of pushing in a loop, use extend.

[kelebra]

I would like to try and tackle this issue. Two questions if you don't mind me asking:

• should I introduce new benchmark for the functionality to measure if the suggestion helped?
• I found another instance of mentioned code pattern (for ... vec.push) in the same file, should I replace it too?

[robertbastian]

There are a few instances across those two crates, they should all be updated. I don't think benchmarks are necessary.

[sffc]

Does #2531 fix this issue?

[robertbastian]

I'm pretty sure there were more than 2 instances

[kelebra]

I can handle remaining instances later today 👍

[sffc]

@hsivonen Can you set an assignee (or "help wanted") and a milestone (or "backlog")?

[sffc]

@hsivonen @kelebra Is this issue fixed?

[kelebra]

I think I addressed all the remaining cases in the PR before, so should be fixed.

[hsivonen]

One instance left still.

[kelebra]

I can take care of that, would you mind assigning this to me?

[sffc]

@kelebra I can't assign the issue since you're not currently in the org, but feel free to contribute a PR!

[sffc]

I take that this is fixed now; thanks, @kelebra!