unicode-org
DRAFT: ICU-22907 MF2: Finish updating spec tests and implement required test functions
Checklist
- [x] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22907
- For minor changes you can use one of the following per-release tickets:
- ICU 77 code warnings/version updates: ICU-22920 — Fix compiler warnings. Update versions of code-related dependencies (e.g., dependabot).
- ICU 77 docs minor fixes: ICU-22921 — User Guide & API docs typos etc., and version updates (e.g., dependabot for User Guide)
- [ ] Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
- [x] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
- [x] Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
- [x] Issue accepted (done by Technical Committee after discussion)
- [x] Tests included, if applicable
- [x] API docs and/or User Guide docs changed or added, if applicable
Notice: the branch changed across the force-push!
- icu4c/source/i18n/messageformat2_function_registry_internal.h is different
~ Your Friendly Jira-GitHub PR Checker Bot
![jira-pull-request-webhook[bot] avatar](https://avatars.githubusercontent.com/u/13873561?v=4 "Published by a pub.dev verified publisher"){kind=small}
Notice: the branch changed across the force-push!
- icu4c/source/i18n/messageformat2.cpp is different
~ Your Friendly Jira-GitHub PR Checker Bot
Notice: the branch changed across the force-push!
- icu4c/source/i18n/messageformat2.cpp is different
~ Your Friendly Jira-GitHub PR Checker Bot
Notice: the branch changed across the force-push!
- icu4c/source/i18n/messageformat2_checker.cpp is different
- icu4c/source/i18n/messageformat2_checker.h is different
- icu4c/source/i18n/messageformat2_data_model.cpp is different
- icu4c/source/i18n/messageformat2_evaluation.cpp is different
- icu4c/source/i18n/messageformat2_evaluation.h is different
- icu4c/source/i18n/messageformat2_formatter.cpp is different
- icu4c/source/i18n/messageformat2_function_registry_internal.h is different
- icu4c/source/i18n/messageformat2_function_registry.cpp is different
- icu4c/source/i18n/messageformat2_parser.cpp is different
- icu4c/source/i18n/messageformat2_parser.h is different
- icu4c/source/i18n/messageformat2_serializer.cpp is different
- icu4c/source/i18n/messageformat2.cpp is different
- icu4c/source/i18n/unicode/messageformat2_data_model.h is different
- icu4c/source/i18n/unicode/messageformat2_formattable.h is different
- icu4c/source/i18n/unicode/messageformat2.h is different
- icu4c/source/test/intltest/messageformat2test_custom.cpp is different
- icu4c/source/test/intltest/messageformat2test_read_json.cpp is different
- icu4c/source/test/intltest/messageformat2test_utils.h is different
- icu4c/source/test/intltest/messageformat2test.cpp is different
- testdata/message2/normalization.json is now changed in the branch
~ Your Friendly Jira-GitHub PR Checker Bot
Notice: the branch changed across the force-push!
- icu4c/source/i18n/messageformat2_checker.cpp is no longer changed in the branch
- icu4c/source/i18n/messageformat2_checker.h is no longer changed in the branch
- icu4c/source/i18n/messageformat2_data_model.cpp is no longer changed in the branch
- icu4c/source/i18n/messageformat2_parser.cpp is no longer changed in the branch
- icu4c/source/i18n/messageformat2_parser.h is no longer changed in the branch
- icu4c/source/i18n/messageformat2_serializer.cpp is no longer changed in the branch
- icu4c/source/i18n/unicode/messageformat2_data_model.h is no longer changed in the branch
- icu4c/source/test/intltest/messageformat2test_custom.cpp is no longer changed in the branch
- icu4c/source/test/intltest/messageformat2test_read_json.cpp is no longer changed in the branch
- icu4c/source/test/intltest/messageformat2test_utils.h is no longer changed in the branch
- icu4c/source/test/intltest/messageformat2test.cpp is no longer changed in the branch
- testdata/message2/alias-selector-annotations.json is no longer changed in the branch
- testdata/message2/icu-test-selectors.json is no longer changed in the branch
- testdata/message2/matches-whitespace.json is no longer changed in the branch
- testdata/message2/more-data-model-errors.json is no longer changed in the branch
- testdata/message2/normalization.json is no longer changed in the branch
- testdata/message2/resolution-errors.json is no longer changed in the branch
- testdata/message2/runtime-errors.json is no longer changed in the branch
- testdata/message2/spec/data-model-errors.json is no longer changed in the branch
- testdata/message2/spec/functions/date.json is no longer changed in the branch
- testdata/message2/spec/functions/datetime.json is no longer changed in the branch
- testdata/message2/spec/functions/integer.json is no longer changed in the branch
- testdata/message2/spec/functions/number.json is no longer changed in the branch
- testdata/message2/spec/functions/string.json is no longer changed in the branch
- testdata/message2/spec/functions/time.json is no longer changed in the branch
- testdata/message2/spec/pattern-selection.json is no longer changed in the branch
- testdata/message2/spec/syntax-errors.json is no longer changed in the branch
- testdata/message2/spec/syntax.json is no longer changed in the branch
- testdata/message2/valid-tests.json is no longer changed in the branch
~ Your Friendly Jira-GitHub PR Checker Bot
Hooray! The files in the branch are the same across the force-push. 😃
~ Your Friendly Jira-GitHub PR Checker Bot
Notice: the branch changed across the force-push!
- icu4c/source/i18n/messageformat2.cpp is different
~ Your Friendly Jira-GitHub PR Checker Bot
@catamorphism and @srl295 What's going on with this one? Do we need new reviewers? Is this still happening?
@catamorphism and @srl295 What's going on with this one? Do we need new reviewers? Is this still happening?
@richgillam I'm currently on medical leave, hopefully returning Feb. 24. In the meantime, it could be reviewed. I hope it's still happening, as it's necessary for spec compliance!
If Steven's okay with this, that's good enough for me. Let's land this.
wfm, it doesn't look like I have the bandwidth :-(
Steven asks some good questions. We should capture them, or a link to this PR, so that we don't forget all about them after merging.
@mihnita (assignee) last chance to weigh in?
