icu icon indicating copy to clipboard operation
icu copied to clipboard

ICU-22721 Enhance #if for locdispnames.cpp

Open lamtrinhdev opened this issue 1 year ago • 3 comments

ICU-22721

Enhance #if for locdispnames.cpp from #if ! UCONFIG_NO_BREAK_ITERATION to #if !UCONFIG_NO_BREAK_ITERATION (remove spacing).

lamtrinhdev avatar Aug 29 '24 07:08 lamtrinhdev

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 29 '24 07:08 CLAassistant

Ok. Please amend the commit, prefixing the commit message with ICU-22721 (including the one space before the rest of the message).

markusicu avatar Aug 29 '24 16:08 markusicu

Dear @markusicu ,

Thank you for your review. I updated the commit message. When yo have team, please help me to review it.

Thanks, Lam

lamtrinhdev avatar Aug 30 '24 01:08 lamtrinhdev

Please squash your commits, and make sure to use the GitHub ID lamtrinhdev which is on record has having signed the CLA.

markusicu avatar Aug 30 '24 22:08 markusicu

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Dear @markusicu ,

Thank you for your feedback. I squash my commits with my GitHub ID. Please help me to review the PR when you have time.

Thanks, Lam

lamtrinhdev avatar Sep 03 '24 13:09 lamtrinhdev

Dear @markusicu ,

I squash my commits with my GitHub ID. Please help me to review the PR when you have time.

Thanks, Lam

lamtrinhdev avatar Sep 06 '24 05:09 lamtrinhdev