icu icon indicating copy to clipboard operation
icu copied to clipboard

ICU-22875 Fixed invisible angle brackets

Open Calorion opened this issue 1 year ago • 5 comments

Made angle brackets and enclosed text visible.

Checklist
  • [x] Required: Issue filed: ICU-22875
  • [x] Required: The PR title must be prefixed with a JIRA Issue number.
  • [x] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • [x] Required: Each commit message must be prefixed with a JIRA Issue number.
  • [ ] Issue accepted (done by Technical Committee after discussion)
  • [x] Tests included, if applicable
  • [x] API docs and/or User Guide docs changed or added, if applicable

Calorion avatar Aug 23 '24 22:08 Calorion

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 23 '24 22:08 CLAassistant

Oh, there is one thing missing: Please amend the commit by prepending the commit message with the ticket and a space: ICU-22875

markusicu avatar Aug 29 '24 16:08 markusicu

I tried; apparently the only way to do that is from the command line.

Calorion avatar Aug 29 '24 17:08 Calorion

I tried; apparently the only way to do that is from the command line.

That appears to be true: https://github.com/orgs/community/discussions/8891

This discussion has some instructions: https://stackoverflow.com/a/67007037 The most important parts are git commit --amend and git push -f

markusicu avatar Aug 29 '24 17:08 markusicu

That's nice. I'm just an end user who noticed a typo. I'm not going to install and learn to use git in order to fix your error.

Calorion avatar Aug 29 '24 23:08 Calorion

replaced by https://github.com/unicode-org/icu/pull/3147

markusicu avatar Sep 10 '24 21:09 markusicu