ICU-22668 Add unit tests (and a temporary fix) for the missing "iso86…

[richgillam]

…01" calendar type. (The real fix will go into

CLDR against CLDR-17892.)

Checklist

• [x] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22668
• [x] Required: The PR title must be prefixed with a JIRA Issue number.
• [x] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
• [x] Required: Each commit message must be prefixed with a JIRA Issue number.
• [x] Issue accepted (done by Technical Committee after discussion)
• [x] Tests included, if applicable
• [ ] API docs and/or User Guide docs changed or added, if applicable

[jira-pull-request-webhook[bot]]

Notice: the branch changed across the force-push!

• icu4c/source/data/locales/root.txt is different
• icu4c/source/test/cintltst/crelativedateformattest.c is different
• icu4c/source/test/cintltst/udatpg_test.c is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[markusicu]

Wait for the CLDR ticket to get resolved.

[roubert]

All the CI test failures in the Azure Pipelines seem to be in the cdattst test, which has to do with date formats, so it wouldn't be all too far-fetched to think that they might actually somehow be caused by the changes in this PR.

[richgillam]

All the CI test failures in the Azure Pipelines seem to be in the cdattst test, which has to do with date formats, so it wouldn't be all too far-fetched to think that they might actually somehow be caused by the changes in this PR.

I hear you, except that this change shouldn't have affected cdattst at all, unless the data change somehow blew it up. More importantly, intltest and iotest are also both crashing too. It looks like intltest is crashing in StaticUnicodeSetsTest/testNonEmpty and iotest is crashing in file/testFile, and I really don't think my change should have messed those up...

But yeah, my other PR seems to be passing all its checks, and these failures have persisted across re-runs and a code change, so maybe I did break it somehow. I'm not sure how I debug that when I don't have access to a Windows machine...

[markusicu]

All the CI test failures in the Azure Pipelines seem to be in the cdattst test, which has to do with date formats, so it wouldn't be all too far-fetched to think that they might actually somehow be caused by the changes in this PR.

I hear you, except that this change shouldn't have affected cdattst at all, unless the data change somehow blew it up. More importantly, intltest and iotest are also both crashing too. It looks like intltest is crashing in StaticUnicodeSetsTest/testNonEmpty and iotest is crashing in file/testFile, and I really don't think my change should have messed those up...

But yeah, my other PR seems to be passing all its checks, and these failures have persisted across re-runs and a code change, so maybe I did break it somehow. I'm not sure how I debug that when I don't have access to a Windows machine...

@mihnita and @eggrobin have Windows machines. @roubert has sometimes run tests on an open source build lab.

[roubert]

@roubert has sometimes run tests on an open source build lab.

That's the GCC Compile Farm and it's a great resource to know about, but it only provides machines running different flavours of Unix (including macOS) and not Windows:

https://gcc.gnu.org/wiki/CompileFarm

[richgillam]

I'd be thrilled if somebody who can build and test on Windows can try this and tell me if the tests are crashing for them and share any information about what's actually crashing...

[richgillam]

Closing this PR in favor of a new one that just has unit tests.