unicode-org
ICU-22762 MF2: Add methods to control error handling behavior
Checklist
- [x] Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22762
- [x] Required: The PR title must be prefixed with a JIRA Issue number.
- [x] Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
- [x] Required: Each commit message must be prefixed with a JIRA Issue number.
- [ ] Issue accepted (done by Technical Committee after discussion)
- [x] Tests included, if applicable
- [x] API docs and/or User Guide docs changed or added, if applicable
Notice: the branch changed across the force-push!
- icu4c/source/i18n/messageformat2_errors.h is different
- icu4c/source/i18n/messageformat2_formatter.cpp is different
- icu4c/source/i18n/unicode/messageformat2.h is different
- icu4c/source/test/intltest/messageformat2test.cpp is different
- icu4c/source/test/intltest/messageformat2test.h is now changed in the branch
~ Your Friendly Jira-GitHub PR Checker Bot
![jira-pull-request-webhook[bot] avatar](https://avatars.githubusercontent.com/u/13873561?v=4 "Published by a pub.dev verified publisher"){kind=small}
Notice: the branch changed across the force-push!
- icu4c/source/i18n/messageformat2_formatter.cpp is different
- icu4c/source/test/intltest/messageformat2test.cpp is different
~ Your Friendly Jira-GitHub PR Checker Bot
Notice: the branch changed across the force-push!
- icu4c/source/i18n/unicode/messageformat2.h is different
~ Your Friendly Jira-GitHub PR Checker Bot
@richgillam @echeran Per a suggestion from @mihnita on the design doc, I added 7e421d4 -- all that does is move the enum definition out of the builder class into the MessageFormatter class.
I didn't change the design doc because I didn't want to edit what was already accepted by TC; thus I'm just making this change in the code but calling attention to it being different from the design doc.
I didn't change the design doc because I didn't want to edit what was already accepted by TC; thus I'm just making this change in the code but calling attention to it being different from the design doc.
At some point, I'm going to have to go through and promote all the new APIs from draft to stable, and part of that process involves verifying that what I'm promoting matches the API proposals that were approved. This will cause hiccups in that process.
I don't object to the actual change, but I think you want to update the proposal to match what you're checking in, and you should probably either go through API review again (hopefully it'd just be a rubber stamp) or at least notify everyone via the icu-design mailing list and give them a chance to object.
@richgillam:
I don't object to the actual change, but I think you want to update the proposal to match what you're checking in, and you should probably either go through API review again (hopefully it'd just be a rubber stamp) or at least notify everyone via the
icu-designmailing list and give them a chance to object.
OK, that makes sense. I changed the design doc to match this code, and emailed the icu-design list.
Notice: the branch changed across the force-push!
- icu4c/source/i18n/messageformat2_data_model.cpp is different
- icu4c/source/i18n/messageformat2_errors.cpp is different
- icu4c/source/i18n/messageformat2_errors.h is different
- icu4c/source/i18n/messageformat2_serializer.cpp is different
- icu4c/source/i18n/messageformat2.cpp is different
- icu4c/source/test/intltest/messageformat2test.cpp is different
~ Your Friendly Jira-GitHub PR Checker Bot
@richgillam:
I don't object to the actual change, but I think you want to update the proposal to match what you're checking in, and you should probably either go through API review again (hopefully it'd just be a rubber stamp) or at least notify everyone via the
icu-designmailing list and give them a chance to object.OK, that makes sense. I changed the design doc to match this code, and emailed the icu-design list.
I added a note for this into the ICU 76 API proposal status doc.
Hooray! The files in the branch are the same across the force-push. 😃
~ Your Friendly Jira-GitHub PR Checker Bot