cldr icon indicating copy to clipboard operation
cldr copied to clipboard

CLDR-18561 hora peninsular

Open robertbastian opened this issue 6 months ago • 9 comments

CLDR-18561

  • [x] This PR completes the ticket.

Adds "hora peninsular" to es, es_ES (Spain), es_EA (Ceuta & Melilla), es_IC (Canaries).

ALLOW_MANY_COMMITS=true

robertbastian avatar May 26 '25 10:05 robertbastian

Notice: the branch changed across the force-push!

  • common/main/es_419.xml is different
  • common/main/es.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Notice: the branch changed across the force-push!

  • common/main/es_GQ.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

We could add "hora de verano peninsular" and "hora estándar peninsular", the ticket just only asked for "hora peninsular".

Also, there seems to be inconsistent usage of "hora" vs "horario", most metazone names use "hora", some use "horario", the specific region formats use "horario", but the generic one uses "hora".

robertbastian avatar Jun 03 '25 11:06 robertbastian

We could add "hora de verano peninsular" and "hora estándar peninsular", the ticket just only asked for "hora peninsular".

Also, there seems to be inconsistent usage of "hora" vs "horario", most metazone names use "hora", some use "horario", the specific region formats use "horario", but the generic one uses "hora".

  • We probably should add for daylight and standard since those will be shorter than the automatically generated ones. I think they're not really using them which is why they aren't requesting them.
  • Should we ask the vetters for feedback on the inconsistency?

AEApple avatar Jun 03 '25 13:06 AEApple

Should we ask the vetters for feedback on the inconsistency?

Yes!

robertbastian avatar Jun 03 '25 15:06 robertbastian

We should also ask vetters whether to use "hora de verano peninsular" or "hora peninsular de verano" (and same for standard).

robertbastian avatar Jun 03 '25 15:06 robertbastian

Looks like we can merge. Robert, do you have permissions for that?

macchiati avatar Jun 03 '25 16:06 macchiati

Do we want to finish the discussion first?

robertbastian avatar Jun 03 '25 16:06 robertbastian

sure

macchiati avatar Jun 03 '25 16:06 macchiati

@AEApple can you check with vetters what the correct specific names are?

robertbastian avatar Jun 26 '25 14:06 robertbastian