cldr icon indicating copy to clipboard operation
cldr copied to clipboard
verified publisher icon unicode-org

CLDR-8386 Issues with Malayalam-Latin/InterIndic transliteration rules

Open cibu opened this issue 5 years ago • 7 comments

Checklist
  • [ x] Issue filed: https://unicode-org.atlassian.net/browse/CLDR-8386
  • [ x] Updated PR title and link in previous line to include Issue number

This is the fix created by Martin Jansche to primarily fix following issue in Malayalam-Latin transforms:

Mlym Correct Current
കോ kō kēā
കൊ ko keā

This patch makes other related changes as well.

Martin's original patch is available at: https://github.com/google/language-resources/commit/58e88645a0e4ca4ecdfff8601847369c3272d745#diff-c1ffded1a01f3ea4e54cce592f4a2205

cibu avatar Apr 30 '20 21:04 cibu

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook[bot] avatar Apr 30 '20 21:04 jira-pull-request-webhook[bot]

Thanks, Cibu.

Peter had the ticket, but I'm sure he'd be happy to pass it on.

Peter, let me know if you want me to review this one.

Mark

On Thu, Apr 30, 2020 at 2:12 PM cibu [email protected] wrote:

Checklist

  • [ x] Issue filed: https://unicode-org.atlassian.net/browse/CLDR-8386
  • [ x] Updated PR title and link in previous line to include Issue number

This is the fix created by Martin Jansche to primarily fix following issue in Malayalam-Latin transforms: Mlym Correct Current കോ kō kēā കൊ ko keā

This patch makes other related changes as well.

Martin's original patch is available at: google/language-resources@58e8864 #diff-c1ffded1a01f3ea4e54cce592f4a2205 https://github.com/google/language-resources/commit/58e88645a0e4ca4ecdfff8601847369c3272d745#diff-c1ffded1a01f3ea4e54cce592f4a2205

You can view, comment on, or merge this pull request online at:

https://github.com/unicode-org/cldr/pull/446 Commit Summary

  • Update Malayalam-Bengali.xml
  • Update Malayalam-Latin.xml
  • Update Malayalam-Tamil.xml
  • Update Malayalam-InterIndic.xml

File Changes

Patch Links:

  • https://github.com/unicode-org/cldr/pull/446.patch
  • https://github.com/unicode-org/cldr/pull/446.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/446, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMGDXGYMKEJ2K53LTVTRPHSUFANCNFSM4MWURW3A .

macchiati avatar Apr 30 '20 21:04 macchiati

The PR will need to have changes in the test files to reflect the changes.

macchiati avatar Apr 30 '20 22:04 macchiati

I am perfectly fine with Peter take care of it. Anyway my patch is not complete with the failing Travis tests.

-Cibu

On Thu, Apr 30, 2020 at 10:38 PM Mark Davis ☕️ [email protected] wrote:

Thanks, Cibu.

Peter had the ticket, but I'm sure he'd be happy to pass it on.

Peter, let me know if you want me to review this one.

Mark

On Thu, Apr 30, 2020 at 2:12 PM cibu [email protected] wrote:

Checklist

  • [ x] Issue filed: https://unicode-org.atlassian.net/browse/CLDR-8386
  • [ x] Updated PR title and link in previous line to include Issue number

This is the fix created by Martin Jansche to primarily fix following issue in Malayalam-Latin transforms: Mlym Correct Current കോ kō kēā കൊ ko keā

This patch makes other related changes as well.

Martin's original patch is available at: google/language-resources@ 58e8864#diff-c1ffded1a01f3ea4e54cce592f4a2205 https://github.com/google/language-resources/commit/58e88645a0e4ca4ecdfff8601847369c3272d745#diff-c1ffded1a01f3ea4e54cce592f4a2205

You can view, comment on, or merge this pull request online at:

https://github.com/unicode-org/cldr/pull/446 Commit Summary

  • Update Malayalam-Bengali.xml
  • Update Malayalam-Latin.xml
  • Update Malayalam-Tamil.xml
  • Update Malayalam-InterIndic.xml

File Changes

Patch Links:

  • https://github.com/unicode-org/cldr/pull/446.patch
  • https://github.com/unicode-org/cldr/pull/446.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/446, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMGDXGYMKEJ2K53LTVTRPHSUFANCNFSM4MWURW3A .

macchiati avatar May 01 '20 12:05 macchiati

Mark is more familiar with the InterIndic transforms and probably a better reviewer for this if he has time...

pedberg-icu avatar May 04 '20 23:05 pedberg-icu

The PR isn't ready since the tests fail. The problem is that this change percolates through all of the mappings from Malayalam to other scripts (and back, I think), so it would take some work to adjust them.

Mark

On Mon, May 4, 2020 at 4:37 PM pedberg-icu [email protected] wrote:

Mark is more familiar with the InterIndic transforms and probably a better reviewer for this if he has time...

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/446#issuecomment-623763567, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMGIEKDH5J3YHSG7VM3RP5GTRANCNFSM4MWURW3A .

macchiati avatar May 05 '20 00:05 macchiati

Hi @cibu I just stumbled over this and noticed it's still open. Looks like it needs rebasing to pick up intermediate changes in these files, and needs test changes to cover the changes in behavior.

markusicu avatar Mar 21 '24 21:03 markusicu