unicode-org
CLDR-16526 spec: link check spec/rfc
- run lychee action
CLDR-16526
- [ ] This PR completes the ticket.
ALLOW_MANY_COMMITS=true
Notice: the branch changed across the force-push!
- .github/workflows/gh-pages.yml is different
~ Your Friendly Jira-GitHub PR Checker Bot
![jira-pull-request-webhook[bot] avatar](https://avatars.githubusercontent.com/u/13873561?v=4 "Published by a pub.dev verified publisher"){kind=small}
https://github.com/unicode-org/cldr/actions/runs/10815398470/job/30004183744#step:11:90
Doesn't warn or error in the PR yet, but does do the run.
Notice: the branch changed across the force-push!
- .github/workflows/gh-pages.yml is different
~ Your Friendly Jira-GitHub PR Checker Bot
Great!
The errors now show up in the summary page for the run: https://github.com/unicode-org/cldr/actions/runs/10816554786
@AEApple @macchiati FYI, try the link above ^
Looks great. Is it everything in docs/ ?
On Wed, Sep 11, 2024, 10:29 Steven R. Loomis @.***> wrote:
Great!
The errors now show up in the summary page for the run: https://github.com/unicode-org/cldr/actions/runs/10816554786
@AEApple https://github.com/AEApple @macchiati https://github.com/macchiati FYI, try the link above ^
— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/4044#issuecomment-2344280695, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMCEQXV7HOG6H7EVE7TZWB4YFAVCNFSM6AAAAABOBJNWZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBUGI4DANRZGU . You are receiving this because you were mentioned.Message ID: @.***>
Looks great. Is it everything in docs/ ?
This one is only docs/ldml and docs/rfc but I can set up similar for site.
LGTM! So are we just going to file another ticket to clean up the initial batch of problematic links?
Yes, we'll need that
On Wed, Sep 11, 2024, 22:20 Annemarie Apple @.***> wrote:
LGTM! So are we just going to file another ticket to clean up the initial batch of problematic links?
— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/4044#issuecomment-2345296397, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMEWCJ5YJRBI2HTBFRLZWEQBRAVCNFSM6AAAAABOBJNWZSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNBVGI4TMMZZG4 . You are receiving this because you were mentioned.Message ID: @.***>
To confirm, this does not block PRs from being merged (we don't want that until we have time to clean them up). Also, does this work for both the site and for the spec?
To confirm, this does not block PRs from being merged (we don't want that until we have time to clean them up).
Correct. Otherwise this PR would show as blocked.
Also, does this work for both the site and for the spec?
No, the site is a separate build step.
So does this just mean that there will be a list of errors after every time someone makes a spec change and it builds? Or is it every time there is a PR? (I wasn't sure if the spec is included in the build step every time a PR is created or only if the PR includes a spec change.)
So does this just mean that there will be a list of errors after every time someone makes a spec change and it builds? Or is it every time there is a PR? (I wasn't sure if the spec is included in the build step every time a PR is created or only if the PR includes a spec change.)
When a PR includes spec changes, you will see a list of errors on the PR.
It'd be great to get this in soon, since it would catch many of our link problems.
I just ran across one: in https://unicode.org/reports/tr35/tr35-general.html#pu_single_unit there is a link on Private-Use Units that fails; should be omitting https://github.com/unicode-org/cldr/edit/main/docs/ldml/. Will this catch that?
It'd be great to get this in soon, since it would catch many of our link problems.
I just ran across one: in https://unicode.org/reports/tr35/tr35-general.html#pu_single_unit there is a link on Private-Use Units that fails; should be omitting
https://github.com/unicode-org/cldr/edit/main/docs/ldml/. Will this catch that?
It should.
@macchiati the link check results will show up here https://github.com/unicode-org/cldr/actions/runs/13181120643