unicode-org
CLDR-15698 Time examples < 10 and > 12
before:
after:
CLDR-15698
- [CLDR-15698 ] This PR completes the ticket.
ALLOW_MANY_COMMITS=true
The output.txt is useful, but best to also have before and after screen shots also. And for the text output, also best to have the before and after.
There is a commit message that fails validation. The message must be of the form:
CLDR-15698
eg
CLDR-15698 Time examples < 10 and > 12
The "Details" button on the "jira-ticket — Commit message for 41fe3cb fails validation" gives you a way to fix that, by squashing. Or you can make a new PR. Let us know on slack if you have trouble with that.
Hooray! The files in the branch are the same across the force-push. 😃
~ Your Friendly Jira-GitHub PR Checker Bot
![jira-pull-request-webhook[bot] avatar](https://avatars.githubusercontent.com/u/13873561?v=4 "Published by a pub.dev verified publisher"){kind=small}
Will the same examples show in the Info Panel?
Yes, the same set shows in the pop-up and the info panel.
Once you are ready for review, change the status to "Ready for Review". I approved, but you'll have to fix the conflicts and ask for a re-review.
Notice: the branch changed across the force-push!
- tools/cldr-code/src/main/java/org/unicode/cldr/test/ExampleGenerator.java is no longer changed in the branch
~ Your Friendly Jira-GitHub PR Checker Bot
Hooray! The files in the branch are the same across the force-push. 😃
~ Your Friendly Jira-GitHub PR Checker Bot
Hooray! The files in the branch are the same across the force-push. 😃
~ Your Friendly Jira-GitHub PR Checker Bot
@e-ikwut needs mvn spotless:apply can you do that? make sure the commit is formatted properly
