CLDR-17754: added Samogitian language

[zordsdavini]

CLDR-17754

• [x] This PR completes the ticket.

ALLOW_MANY_COMMITS=true

[CLAassistant]

All committers have signed the CLA.

[zordsdavini]

I checked errors and have problem

/home/runner/work/cldr/cldr/common/main/sgs.xml:18:110: error
sgs [Samogitian]	error	▸Core_Data|Alphabetic_Information|Characters_in_Use|Main_Letters◂	〈[a b c d e f g h i j k l m n o p q r s t u v w x y z]〉	【】	〈[aā b c č d eē ėė̄ f g h iī j k l m n oō p r s š t uū v z ž]〉	«=»	【】	⁅illegal characters in exemplars⁆	❮Error: Should be limited to (specific-script - uppercase - invisibles + İ); thus not contain: ‎[\u0304]‎❯	https://st.unicode.org/cldr-apps/v#/sgs//7ed88347aa1b55ed
Error:  Error: Should be limited to (specific-script - uppercase - invisibles + İ); thus not contain: ‎[\u0304]‎

We have letter "ė̄" (ė with macron or e with dot above and macron), ex.: gerė̄jē. Mostly we write it with ė and adding macron (\u0304). Unicode doesn't have such single letter and didn't want to add when we asked to do that. What should we do here? And we have keylayout with macron as separate key, so all ā, ē, ī, ō, ė̄, ū we can write in combination with \u0304

[macchiati]

Any sequence of characters can be included with {...}. For example,

{ė\u0304}

On Sun, Aug 11, 2024 at 12:08 PM Arnas Udovič @.***> wrote:

I checked errors and have problem

/home/runner/work/cldr/cldr/common/main/sgs.xml:18:110: error sgs [Samogitian] error ▸Core_Data|Alphabetic_Information|Characters_in_Use|Main_Letters◂ 〈[a b c d e f g h i j k l m n o p q r s t u v w x y z]〉 【】 〈[aā b c č d eē ėė̄ f g h iī j k l m n oō p r s š t uū v z ž]〉 «=» 【】 ⁅illegal characters in exemplars⁆ ❮Error: Should be limited to (specific-script - uppercase - invisibles + İ); thus not contain: ‎[\u0304]‎❯ https://st.unicode.org/cldr-apps/v#/sgs//7ed88347aa1b55ed Error: Error: Should be limited to (specific-script - uppercase - invisibles + İ); thus not contain: ‎[\u0304]‎

We have letter "ė̄" (ė with macron or e with dot above and macron), ex.: gerė̄jē. Mostly we write it with ė and adding macron (\u0304). Unicode doesn't have such single letter and didn't want to add when we asked to do that. What should we do here? And we have keylayout with macron as separate key, so all ā, ē, ī, ō, ė̄, ū we can write in combination with \u0304

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3818#issuecomment-2282858648, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMDRZXHHQGDQHDO6DOLZQ6ZBBAVCNFSM6AAAAABJVXPOASVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEOBSHA2TQNRUHA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[jira-pull-request-webhook[bot]]

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

[zordsdavini]

Should I add something more or do something because of failed build? The error looks very unrelated but maybe I am wrong?

[DavidLRowe]

@srl295 Can you advise on test failures being reported here?

[zordsdavini]

@srl295 is this branch merged or just deleted?

[srl295]

@zordsdavini Did not see this one (i thought only @conradarcturus was using that branch)

can you fix your commit so that it doesn't have the colon in it?

If you click Details you can choose the Squash option there.

[jira-pull-request-webhook[bot]]

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

[zordsdavini]

@srl295 tried to fix. I hope I did it correctly

[jira-pull-request-webhook[bot]]

Notice: the branch changed across the force-push!

• common/main/sgs.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[zordsdavini]

@conradarcturus should I do something more to make this move forward?

[jira-pull-request-webhook[bot]]

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

[srl295]

Needs tests to pass, then we can merge.

[jira-pull-request-webhook[bot]]

Notice: the branch changed across the force-push!

• common/main/sgs.xml is different
• common/supplemental/plurals.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[zordsdavini]

@srl295 I didn't noted your comment. Tried to understand the problem and fixed. At the beginning I followed LT rules, but it looks a little bit messy here, so I rewrote SGS part. Now it gives some conflict and needs to be reviewed

[srl295]

@zordsdavini you got bit by something unrelated. Are you able to merge in the latest from CLDR main? something like:

• git fetch upstream
• git merge -m 'CLDR-17754 merge from main' upstream/main

[zordsdavini]

@srl295 I updated with github tool. Will it work?

[srl295]

@zordsdavini possibly.

the title of the merge commit needed to start with CLDR-17754 or the tooling will complain

[jira-pull-request-webhook[bot]]

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

[srl295]

@conradarcturus do you still have issues or can you approve?

[zordsdavini]

@srl295 this merge brought more issues. It should be rebased instead merged – now it complains about something in the middle. Second - tests with plural rules is failing. I don't understand why it gives zero. Here it is log:

Error:  (TestSupplementalInfo.java:743)  Error: : sgs, 2, one: expected false, got true

Error:  (TestSupplementalInfo.java:743)  Error: : sgs, 3, one: expected false, got true

Error:  (TestSupplementalInfo.java:743)  Error: : sgs, 4, one: expected false, got true

Error:  (TestSupplementalInfo.java:743)  Error: : sgs, 2, two: expected true, got false

Error:  (TestSupplementalInfo.java:743)  Error: : sgs, 3, two: expected true, got false

Error:  (TestSupplementalInfo.java:743)  Error: : sgs, 4, two: expected true, got false
To fix the above, review the following, then replace in TestDigitPluralCompleteness
{"sgs", "one", "0,00,000,0000"},	// n % 10 = 1 and n % 100 != 11
{"sgs", "two", "0"},	// n = 2

[srl295]

@srl295 this merge brought more issues. It should be rebased instead merged – now it complains about something in the middle. Second - tests with plural rules is failing. I don't understand why it gives zero. Here it is log:

Error:  (TestSupplementalInfo.java:743)  Error: : sgs, 2, one: expected false, got true

Error:  (TestSupplementalInfo.java:743)  Error: : sgs, 3, one: expected false, got true

Error:  (TestSupplementalInfo.java:743)  Error: : sgs, 4, one: expected false, got true

Error:  (TestSupplementalInfo.java:743)  Error: : sgs, 2, two: expected true, got false

Error:  (TestSupplementalInfo.java:743)  Error: : sgs, 3, two: expected true, got false

Error:  (TestSupplementalInfo.java:743)  Error: : sgs, 4, two: expected true, got false
To fix the above, review the following, then replace in TestDigitPluralCompleteness
{"sgs", "one", "0,00,000,0000"},	// n % 10 = 1 and n % 100 != 11
{"sgs", "two", "0"},	// n = 2

I think they are only relevant issues. I'll take a look. Shouldn't need to rebase.

[conradarcturus]

Oh darn, you hit the dreaded exemption that the there is are new exemplar characters.

Do you have the CLDR environment set up? You can run the command below to rebuild the exemplar characters.

mvn -DSHOW_EXEMPLARS test --file tools/pom.xml '-Dorg.unicode.cldr.unittest.testArgs=-f:LikelySubtagsTest -n -q'

If you don't, I can make a separate pull request to add the sgs.xml -- then you can rebase this change on that for your plural changes.

[zordsdavini]

@conradarcturus

Need to rebuild exemplars:

Tried but got error:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.11.0:compile (default-compile) on project cldr-code: Fatal error compiling: error: release version 11 not supported -> [Help 1]

[conradarcturus]

We're running into many random test issues -- thanks for your patience @zordsdavini . Since we're opening the Survey Tool I want to unblock the locale so I made a separate PR that should add the code data for Samogitian -- I realized there were a few other files that needed to be updated too. https://github.com/unicode-org/cldr/pull/4621

If that looks good, we can rebase your change after we land that so you can add the plural rules.

[zordsdavini]

@conradarcturus yes, let's move on. Sometimes it is better in small steps but forward

[conradarcturus]

I landed the previously mentioned PR. You should be able to rebase this one now. There may be minor merge conflicts -- Note I had some tab/space fixes.

[jira-pull-request-webhook[bot]]

Notice: the branch changed across the force-push!

• common/main/sgs_LT.xml is no longer changed in the branch
• common/main/sgs.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

[zordsdavini]

@conradarcturus I've made rebase with new your updates