cldr icon indicating copy to clipboard operation
cldr copied to clipboard
verified publisher icon unicode-org

CLDR-16835 DDL announcement

Open srl295 opened this issue 1 year ago • 13 comments

(Note: waiting for #3795 )

CLDR-16835

  • Announcement UI to announce to Non-TC locales, and/or Non-TC orgs

  • [ ] This PR completes the ticket.

Supports CLDR-16614

ALLOW_MANY_COMMITS=true

Example view of the announcements panel

image

Example view of posting

image

srl295 avatar Jun 11 '24 16:06 srl295

What does ! mean in the Locales field? Is that a magic character?

macchiati avatar Jun 11 '24 23:06 macchiati

What does ! mean in the Locales field? Is that a magic character?

Magic for now but could be a button in the UI.

srl295 avatar Jun 12 '24 00:06 srl295

Could you for now just add a text note below the box that has the magic symbols and what they mean?

On Tue, Jun 11, 2024 at 5:01 PM Steven R. Loomis @.***> wrote:

What does ! mean in the Locales field? Is that a magic character?

Magic for now but could be a button in the UI.

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3796#issuecomment-2161812899, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEME6DQ3XO262WSDA22TZG6FUNAVCNFSM6AAAAABJEUSTUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRHAYTEOBZHE . You are receiving this because you commented.Message ID: @.***>

macchiati avatar Jun 12 '24 00:06 macchiati

Could you for now just add a text note below the box that has the magic

symbols and what they mean?

On Tue, Jun 11, 2024 at 5:01 PM Steven R. Loomis @.***>

wrote:

What does ! mean in the Locales field? Is that a magic character?

Magic for now but could be a button in the UI.

—

Reply to this email directly, view it on GitHub

https://github.com/unicode-org/cldr/pull/3796#issuecomment-2161812899,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/ACJLEME6DQ3XO262WSDA22TZG6FUNAVCNFSM6AAAAABJEUSTUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRHAYTEOBZHE

.

You are receiving this because you commented.Message ID:

@.***>

There's a note in the box, see other comment. Does that work?

srl295 avatar Jun 12 '24 02:06 srl295

Optional list of locales (like: aa fr zh) (fr implies fr_CA/etc.) (empty for all locales, '!' for non-TC)

A bit too telegraphic. If you haven't merged yet, I suggest:

=>

If empty, all locales; If !, then all non-TC locales; otherwise a specific list, eg: aa fr zh. Note: fr means all sublocales: fr_CA …

On Tue, Jun 11, 2024 at 7:06 PM Steven R. Loomis @.***> wrote:

Could you for now just add a text note below the box that has the magic

symbols and what they mean?

On Tue, Jun 11, 2024 at 5:01 PM Steven R. Loomis @.***>

wrote:

What does ! mean in the Locales field? Is that a magic character?

Magic for now but could be a button in the UI.

—

Reply to this email directly, view it on GitHub

#3796 (comment) https://github.com/unicode-org/cldr/pull/3796#issuecomment-2161812899,

or unsubscribe

https://github.com/notifications/unsubscribe-auth/ACJLEME6DQ3XO262WSDA22TZG6FUNAVCNFSM6AAAAABJEUSTUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRHAYTEOBZHE

.

You are receiving this because you commented.Message ID:

@.***>

There's a note in the box, see other comment. Does that work?

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3796#issuecomment-2161963224, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMHFLCKG4T4MPSYY3B3ZG6UKNAVCNFSM6AAAAABJEUSTUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRRHE3DGMRSGQ . You are receiving this because you were mentioned.Message ID: @.***>

macchiati avatar Jun 12 '24 17:06 macchiati

Optional list of locales (like: aa fr zh) (fr implies fr_CA/etc.) (empty for all locales, '!' for non-TC) A bit too telegraphic. If you haven't merged yet, I suggest: => If empty, all locales; If !, then all non-TC locales; otherwise a specific list, eg: aa fr zh. Note: fr means all sublocales:

@macchiati i do appreciate the feedback. and it makes sense.

Timing wise, this can't merge until #3795 merges. So it will be out for review again once that has happened.

srl295 avatar Jun 12 '24 17:06 srl295

Notice: the branch changed across the force-push!

  • tools/cldr-apps/js/src/esm/cldrLoad.mjs is no longer changed in the branch
  • tools/cldr-apps/js/src/esm/cldrStatus.mjs is no longer changed in the branch
  • tools/cldr-apps/js/src/views/MainHeader.vue is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/util/CLDRConfigImpl.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/DataPage.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/SurveyAjax.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/SurveyMain.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/UserRegistry.java is no longer changed in the branch
  • tools/cldr-code/src/main/java/org/unicode/cldr/test/SubmissionLocales.java is no longer changed in the branch
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/CLDRConfig.java is no longer changed in the branch
  • tools/cldr-code/src/test/java/org/unicode/cldr/test/TestSubmissionLocales.java is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook[bot] avatar Jun 13 '24 16:06 jira-pull-request-webhook[bot]

@btangmu @macchiati this is now ready. Note it is TC locales, not extended submission locales.

srl295 avatar Jun 13 '24 16:06 srl295

Whoops, misread this as pertaining to the other ticket.

Yes, I can confirm that! And apologies, because of how we use merges, this PR had unrelated commits in it earlier while a draft, so that makes it confusing.

I had put this PR out there for UI review.

I think this is an advance, but we will probably want the ability to send to these groups as well. (we can probably work around it for now.)

  1. Vetters with at least one locale that allows submission during vetting
  2. Vetters without at least one locale that allows submission during vetting

Good idea.

In the short term (even without this PR) that can be accomplished by pasting an explicit list into the 'locales' list. I did confirm that the database has a limit on how many locales can be put there! looks like 122 characters (space separated) of locales.

srl295 avatar Jun 13 '24 17:06 srl295

@btangmu want to review the js / vue ?

srl295 avatar Jun 13 '24 17:06 srl295

image

UI idea.. the locales box goes away if 'All' or 'DDL' is chosen.

srl295 avatar Jun 13 '24 20:06 srl295

That would be much cleaner.

On Thu, Jun 13, 2024 at 1:49 PM Steven R. Loomis @.***> wrote:

image.png (view on web) https://github.com/unicode-org/cldr/assets/855219/f6f4711c-e4fd-4b3a-bb9f-06011b84f60e

UI idea.. the locales box goes away if 'All' or 'DDL' is chosen.

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3796#issuecomment-2166757897, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMEESP66UABMSANFHCTZHIAU7AVCNFSM6AAAAABJEUSTUCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRWG42TOOBZG4 . You are receiving this because you were mentioned.Message ID: @.***>

macchiati avatar Jun 13 '24 22:06 macchiati

image UI idea.. the locales box goes away if 'All' or 'DDL' is chosen.

Updated as above. Also the Post button is dimmed if body, subject, locales aren't filled in properly.

Feel free to review. Let's consider merge AFTER Monday's festivities, perhaps with a stint on cldr-staging.

srl295 avatar Jun 14 '24 23:06 srl295