cldr icon indicating copy to clipboard operation
cldr copied to clipboard
verified publisher icon unicode-org

CLDR-18450 improve Dashboard robustness

Open srl295 opened this issue 1 year ago • 3 comments

  • use second param to callback() to return err instead of global
  • popup err message if dashboard fails to load

CLDR-18450

  • [ ] This PR completes the ticket.

ALLOW_MANY_COMMITS=true

srl295 avatar Jun 03 '24 17:06 srl295

Maybe make fetchErr.value explicit where fetchErr is referenced near top of DashboardWidget.vue? And/or add a comment. We should test carefully after merging since there have been changes to these files in the meantime for virtual scroller; still it looks to me like they shouldn't be in conflict.

Right.

The change from created() to mounted() looks potentially important, I wonder if it might affect the "blinky" appearance we were discussing...

https://vuejs.org/guide/essentials/lifecycle.html actually, created() might be better so that it does NOT blink.

srl295 avatar Jun 07 '24 13:06 srl295

This PR should either be abandoned or a new ticket created targetting a later release.

AEApple avatar Jan 21 '25 22:01 AEApple

Notice: the branch changed across the force-push!

  • tools/cldr-apps/js/src/esm/cldrDash.mjs is no longer changed in the branch
  • tools/cldr-apps/js/src/esm/cldrDashData.mjs is now changed in the branch
  • tools/cldr-apps/js/src/views/DashboardWidget.vue is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook[bot] avatar Mar 24 '25 16:03 jira-pull-request-webhook[bot]