CLDR-13523 add test for valid short day length; fix resulting data errs
CLDR-13523
- [x] This PR completes the ticket.
CheckDates had tests that abbreviated date symbols were no longer than wide (error), and that narrow date symbols were no longer than abbreviated (warning). But there was no test for short date symbols (only present in weekday names). Added a test that short days are no longer than abbreviated, and no shorter than narrow (both errors). Checked the with width both with a glyph width estimate (as used for the other tests) and a a string length test, since the test was too sensitive otherwise (e.g. it failed on letter case differences).
Ran the test and fixed the resulting new data errors:
fil: replaced current standalone narrow (same as abbreviated) with format short (shorter)mai: replaced the one provided short value (which was too long) with ↑↑↑ like the other short values, to inherit from abbreviated.mgo: swapped the narrow (in standalone) and short (in format) forms to get the right length ordering.sa: replace short (English abbreviated names) with inheritance from abbreviated (in Sanskrit)so: replaced the one provided standalone short value (too long) with ↑↑↑ like the other standalone short values, to inherit from format short which inherits from format abbreviated.
ALLOW_MANY_COMMITS=true
Looks good to me, but can't approve til tomorrow
On Tue, May 21, 2024, 20:36 Peter Edberg @.***> wrote:
@pedberg-icu https://github.com/pedberg-icu requested your review on: #3739 https://github.com/unicode-org/cldr/pull/3739 CLDR-13523 https://unicode-org.atlassian.net/browse/CLDR-13523 add test for valid short day length; fix resulting data errs.
— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3739#event-12887804649, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMFQHQV6MKRBVDANQBLZDQHDTAVCNFSM6AAAAABICYX2KOVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSHA4DOOBQGQ3DIOI . You are receiving this because your review was requested.Message ID: @.***>
Any TC member, please feel free to merge when approved, thanks.
Per TC discussion 2024-05-22, decided to remove draft="contributed" and make the changes all approved.
Hooray! The files in the branch are the same across the force-push. 😃
~ Your Friendly Jira-GitHub PR Checker Bot