cldr icon indicating copy to clipboard operation
cldr copied to clipboard

CLDR-16499 Prepare to Require a CLA for contributions

Open srl295 opened this issue 1 year ago • 5 comments

CLDR-16499

For v46, we do NOT require a CLA, but leave the code in place for the future

  • property REQUIRE_CLA off by default, if on it will enable the flow

  • no popups or menu items visible to users

  • enables loading .md files to the front end and as assets

  • improve cldrClient.getClient() to cache, speedup repeated calls

  • add notice for synchronizing webpack configuration

  • APIs for sign/revoke/read CLA

  • web flow for signing CLA and handling various cases

  • [ ] This PR completes the ticket.

ALLOW_MANY_COMMITS=true

srl295 avatar Apr 23 '24 00:04 srl295

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@btangmu I'll fix this so that the unit tests don't need to sign a CLA !

I'm just wondering if for local testing we want a switch that auto-signs the CLA? But then again, if you create a vetter in a signing org such as Apple Google Microsoft then it won't ask for a CLA.

srl295 avatar Apr 26 '24 14:04 srl295

@btangmu i think this could get any feedback from you if you want to provide it, knowing we still need to review the text and the overall process. But let me know if you see any structural issues.

srl295 avatar Apr 26 '24 15:04 srl295

remove the commented-out code change for MainMenu.vue?

I made a couple other nit-picky comments (which I don't insist on), otherwise, it all looks great

the menu item was removed because it's not relevant while CLAs are not required. I've changed it to being driven by a constant.

srl295 avatar May 30 '24 16:05 srl295

@btangmu ready to review for merging and mothballing.

srl295 avatar May 30 '24 16:05 srl295

@btangmu I'll fixup this one and get it in. It has a number of general improvements.

srl295 avatar Sep 04 '24 16:09 srl295

@btangmu @macchiati this is ready to go in. it is disabled by default, but gets all the mechanism for requiring a CLA in place (just pending wording changes)

srl295 avatar Sep 06 '24 14:09 srl295

@macchiati Tom had previously approved, just had merge conflicts.

srl295 avatar Sep 06 '24 17:09 srl295