cldr icon indicating copy to clipboard operation
cldr copied to clipboard

CLDR-17519 Move English data of subdivisions to root

Open garywade opened this issue 1 year ago • 10 comments

Moved the contents of localeDisplayNames in en.xml of subdivisions to root.xml so all locales will have fallback data.

CLDR-17519

  • [x] This PR completes the ticket.

ALLOW_MANY_COMMITS=true

garywade avatar Apr 05 '24 22:04 garywade

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Apr 05 '24 22:04 CLAassistant

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@garywade @DraganBesevic @richgillam Gary, Apple already has a CLA with Unicode that covers the contributions of all Apple employees, so do not sign an individual CLA. Your name just needs to be added to the list of Apple contributors. Dragan or Rich, I think you need to e-mail Steven or Markus to get Rich added to the list of people covered by the Apple CLA.

pedberg-icu avatar Apr 06 '24 02:04 pedberg-icu

Moving the subdivision codes to root should be put on the Design group agenda.

For other data we have tried to specifically make the root locale data has neutral as possible so that translators don't simply use the English when it's inappropriate.

On Fri, Apr 5, 2024, 20:13 Peter Edberg @.***> wrote:

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement https://cla-assistant.io/unicode-org/cldr?pullRequest=3616 before we can accept your contribution.

@garywade https://github.com/garywade @DraganBesevic https://github.com/DraganBesevic @richgillam https://github.com/richgillam Gary, Apple already has a CLA with Unicode that covers the contributions of all Apple employees, so do not sign an individual CLA. Your name just needs to be added to the list of Apple contributors. Dragan or Rich, I think you need to e-mail Steven or Markus to get Rich added to the list of people covered by the Apple CLA.

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3616#issuecomment-2040885687, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMBGIVRKH3QY5IFGITLY35K4NAVCNFSM6AAAAABFZ27JT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQHA4DKNRYG4 . You are receiving this because your review was requested.Message ID: @.***>

macchiati avatar Apr 06 '24 16:04 macchiati

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckDisplayCollisions.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

I added to the design meeting agenda. We talked a bit about subdivisions at this week's meeting, but with no conclusion; it would be good if you could join a future meeting, Gary.

On Mon, Apr 8, 2024 at 4:54 PM jira-pull-request-webhook[bot] < @.***> wrote:

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckDisplayCollisions.java is now changed in the branch

View Diff Across Force-Push https://github.com/unicode-org/cldr/compare/unicode-org:3b9db1c..unicode-org:2d9826e

~ Your Friendly Jira-GitHub PR Checker Bot

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3616#issuecomment-2043888825, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMGQUYLEHTEMDUDFKHTY4MU45AVCNFSM6AAAAABFZ27JT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBTHA4DQOBSGU . You are receiving this because your review was requested.Message ID: @.***>

macchiati avatar Apr 09 '24 00:04 macchiati

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckDisplayCollisions.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

I added to the design meeting agenda. We talked a bit about subdivisions at this week's meeting, but with no conclusion; it would be good if you could join a future meeting, Gary.

@macchiati I didn't catch this early enough to join on Monday. Would it help to join the Wednesday morning CLDR-TC meeting?

garywade avatar Apr 09 '24 21:04 garywade

We won't discuss in the main meeting until we have a recommendation from the design team. So the design meeting is the right one to attend. There's no real urgency because the current release is closed for new additions.

On Tue, Apr 9, 2024, 14:30 garywade @.***> wrote:

I added to the design meeting agenda. We talked a bit about subdivisions at this week's meeting, but with no conclusion; it would be good if you could join a future meeting, Gary.

@macchiati https://github.com/macchiati I didn't catch this early enough to join on Monday. Would it help to join the Wednesday morning CLDR-TC meeting?

— Reply to this email directly, view it on GitHub https://github.com/unicode-org/cldr/pull/3616#issuecomment-2046083083, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACJLEMEF42HKYAL6PML2BG3Y4RMY5AVCNFSM6AAAAABFZ27JT2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBWGA4DGMBYGM . You are receiving this because you were mentioned.Message ID: @.***>

macchiati avatar Apr 09 '24 22:04 macchiati

I converted to Draft until the issue is resolved in the Design meeting. Let us know when you want to attend.

macchiati avatar Aug 19 '24 23:08 macchiati

BTW, I reviewed this again, and I can support it in the design meeting. However, a corresponding change needs to be made in the code that updates from ISO and Wikidata; otherwise the data will drift away from reality.

macchiati avatar Mar 23 '25 01:03 macchiati