cldr
cldr copied to clipboard
CLDR-17492 j:(deps): Bump com.google.myanmartools:myanmar-tools from 1.1.1 to 1.2.0 in /tools
Bumps com.google.myanmartools:myanmar-tools from 1.1.1 to 1.2.0.
Release notes
Sourced from com.google.myanmartools:myanmar-tools's releases.
Version 1.2.0: Updated model with Pali, Mon, and Karen
I'm pleased to announce version 1.2.0 of Myanmar Tools. The change in this version is a new model that was trained on additional data in the Pali, Mon, and Karen languages, helping increase accuracy in those languages.
The new version has been pushed to npm, Packagist, RubyGems, PyPI, and Maven Central. It will be updated in a few days on Google Hosted Libraries.
Commits
- See full diff in compare view
You can trigger a rebase of this PR by commenting @dependabot rebase.
Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.
@sffc this causes some failures
TestMyanmarZawgyi
Error: (TestDisplayAndInputProcessor.java:182) Error: Myanmar with diacritics and zero incorrectly normalized:
ေ၀့ to
ေ၀့
ဝေ့
are the tests wrong?
(Also see CLDR-14549 )
I think it's covering this line:
// Use the myanmar-tools detector.
private String standardizeMyanmar(String value) {
if (detector.getZawgyiProbability(value) > 0.90) {
return zawgyiUnicodeTransliterator.transform(value);
}
return value;
}
The string in question has Zawgyi probability 0.7571 in the latest Myanmar Tools, so it's no longer being converted by the above function, which requires 0.90. It's possible that it had a higher probability (greater than 0.90) in the older version.
https://sffc.github.io/myanmar-tools-demos/detector_demo.html#s=%20%E1%80%B1%E1%81%80%E1%80%B7
@sffc should the string be removed?
Ok you can remove the string from the test, and I filed https://github.com/google/myanmar-tools/issues/116 to investigate further.