cldr icon indicating copy to clipboard operation
cldr copied to clipboard

CLDR-17492 j:(deps): Bump com.google.myanmartools:myanmar-tools from 1.1.1 to 1.2.0 in /tools

Open dependabot[bot] opened this issue 2 years ago • 4 comments

Bumps com.google.myanmartools:myanmar-tools from 1.1.1 to 1.2.0.

Release notes

Sourced from com.google.myanmartools:myanmar-tools's releases.

Version 1.2.0: Updated model with Pali, Mon, and Karen

I'm pleased to announce version 1.2.0 of Myanmar Tools. The change in this version is a new model that was trained on additional data in the Pali, Mon, and Karen languages, helping increase accuracy in those languages.

The new version has been pushed to npm, Packagist, RubyGems, PyPI, and Maven Central. It will be updated in a few days on Google Hosted Libraries.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

dependabot[bot] avatar Aug 01 '23 08:08 dependabot[bot]

@sffc this causes some failures

    TestMyanmarZawgyi
Error:  (TestDisplayAndInputProcessor.java:182)  Error: Myanmar with diacritics and zero incorrectly normalized:
ေ၀့ to
ေ၀့
ဝေ့

are the tests wrong?

(Also see CLDR-14549 )

srl295 avatar Aug 01 '23 19:08 srl295

I think it's covering this line:

    // Use the myanmar-tools detector.
    private String standardizeMyanmar(String value) {
        if (detector.getZawgyiProbability(value) > 0.90) {
            return zawgyiUnicodeTransliterator.transform(value);
        }
        return value;
    }

The string in question has Zawgyi probability 0.7571 in the latest Myanmar Tools, so it's no longer being converted by the above function, which requires 0.90. It's possible that it had a higher probability (greater than 0.90) in the older version.

https://sffc.github.io/myanmar-tools-demos/detector_demo.html#s=%20%E1%80%B1%E1%81%80%E1%80%B7

sffc avatar Aug 01 '23 21:08 sffc

@sffc should the string be removed?

srl295 avatar Dec 26 '23 21:12 srl295

Ok you can remove the string from the test, and I filed https://github.com/google/myanmar-tools/issues/116 to investigate further.

sffc avatar Dec 27 '23 00:12 sffc