cldr icon indicating copy to clipboard operation
cldr copied to clipboard

CLDR-16292 Update supplemental/ordinals.xml for Spanish ordinal numbers of ~1 and ~3

Open gosplit opened this issue 2 years ago • 7 comments

Spanish ordinal numbers First and Third will drop o in masculine adjective forms. e.g., 1st day, 2nd day, 3rd day, 4th day, 5th day (English)= 1ᵉʳ día, 2º día, 3ᵉʳ día, 4º día, 5º día (Spanish)

The supplemental/ordinals.xml should be updated accordingly.

Reference 1: CLDR rbnf of es: https://github.com/unicode-org/cldr/blob/835e0c982ed37f994c6363909d958e1731693c03/common/rbnf/es.xml#L289-L297

Reference 2: https://www.spanish.academy/blog/ordinal-numbers/

CLDR-16292

  • [x] This PR completes the ticket.

ALLOW_MANY_COMMITS=true

gosplit avatar Mar 09 '23 09:03 gosplit

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Mar 09 '23 09:03 CLAassistant

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

Notice: the branch changed across the force-push!

  • common/rbnf/es_419.xml is now changed in the branch
  • common/rbnf/es.xml is now changed in the branch
  • common/supplemental/ordinals.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

So if you're trying to fix the RBNF ordinal digit rules in this pull request, then you'll need to use the ordinal rule syntax, just like the English rules.

diff --git a/common/rbnf/es.xml b/common/rbnf/es.xml
index 2ce8d8d3ab..c995eda2bf 100644
--- a/common/rbnf/es.xml
+++ b/common/rbnf/es.xml
@@ -286,18 +286,9 @@ For terms of use, see http://www.unicode.org/copyright.html
             </ruleset>
         </rulesetGrouping>
         <rulesetGrouping type="OrdinalRules">
-            <ruleset type="dord-mascabbrev" access="private">
-                <rbnfrule value="0">º;</rbnfrule>
-                <rbnfrule value="1">ᵉʳ;</rbnfrule>
-                <rbnfrule value="2">º;</rbnfrule>
-                <rbnfrule value="3">ᵉʳ;</rbnfrule>
-                <rbnfrule value="4">º;</rbnfrule>
-                <rbnfrule value="20">→→;</rbnfrule>
-                <rbnfrule value="100">→→;</rbnfrule>
-            </ruleset>
             <ruleset type="digits-ordinal-masculine-adjective">
                 <rbnfrule value="-x">−→→;</rbnfrule>
-                <rbnfrule value="0">=#,##0=.=%%dord-mascabbrev=;</rbnfrule>
+                <rbnfrule value="0">=#,##0=.$(ordinal,one{ᵉʳ}other{º})$;</rbnfrule>
             </ruleset>
             <ruleset type="digits-ordinal-masculine">
                 <rbnfrule value="-x">−→→;</rbnfrule>
diff --git a/common/rbnf/es_419.xml b/common/rbnf/es_419.xml
index f0d135ded7..442667c32d 100644
--- a/common/rbnf/es_419.xml
+++ b/common/rbnf/es_419.xml
@@ -13,18 +13,9 @@ For terms of use, see http://www.unicode.org/copyright.html
     </identity>
     <rbnf>
         <rulesetGrouping type="OrdinalRules">
-            <ruleset type="dord-mascabbrev" access="private">
-                <rbnfrule value="0">º;</rbnfrule>
-                <rbnfrule value="1">ᵉʳ;</rbnfrule>
-                <rbnfrule value="2">º;</rbnfrule>
-                <rbnfrule value="3">ᵉʳ;</rbnfrule>
-                <rbnfrule value="4">º;</rbnfrule>
-                <rbnfrule value="20">→→;</rbnfrule>
-                <rbnfrule value="100">→→;</rbnfrule>
-            </ruleset>
             <ruleset type="digits-ordinal-masculine-adjective">
                 <rbnfrule value="-x">−→→;</rbnfrule>
-                <rbnfrule value="0">=#,##0==%%dord-mascabbrev=.;</rbnfrule>
+                <rbnfrule value="0">=#,##0=$(ordinal,one{ᵉʳ}other{º})$.;</rbnfrule>
             </ruleset>
             <ruleset type="digits-ordinal-masculine">
                 <rbnfrule value="-x">−→→;</rbnfrule>

grhoten avatar Jun 27 '23 19:06 grhoten

FYI the current RBNF rules don't work correctly. It's kind of hacked together. You can see the parsing issue in the Number Format Tester in a big red warning. This syntax with the revised rules will resolve that issue.

grhoten avatar Jun 27 '23 19:06 grhoten