cldr icon indicating copy to clipboard operation
cldr copied to clipboard
verified publisher icon unicode-org

CLDR-15656 refactor DB stuff out of UserRegistry

Open srl295 opened this issue 3 years ago • 4 comments

CLDR-15656 refactor DB stuff out of UserRegistry

  • DBUserRegistry for 'normal' db use, and a MemoryUserRegistry (in the test tree) for testing
  • remove the isLocaleAliased() mechanism, since //ldml/alias has been obsolete for a long time

CLDR-15656

  • [ ] This PR completes the ticket.

srl295 avatar May 18 '22 22:05 srl295

Notice: the branch changed across the force-push!

  • tools/cldr-apps/src/test/java/org/unicode/cldr/unittest/web/TestSTFactory.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook[bot] avatar May 19 '22 16:05 jira-pull-request-webhook[bot]

Notice: the branch changed across the force-push!

  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/api/Summary.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/api/VoteAPIHelper.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/DBUserRegistry.java is different
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/MemoryUserRegistry.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/STFactory.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/SurveyAjax.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/SurveyMain.java is different
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/UserRegistry.java is different
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/WebContext.java is no longer changed in the branch
  • tools/cldr-apps/src/test/java/org/unicode/cldr/web/MemoryUserRegistry.java is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook[bot] avatar May 19 '22 17:05 jira-pull-request-webhook[bot]

massive conflicts now - will have to pick this up again another time

srl295 avatar Oct 20 '22 18:10 srl295

@btangmu As you can imagine, this PR from may 2022 is more than a little bit bit-rotten…

but I think it is a worthwhile effort, so I'm going to start on redoing it. The basic process is to make UserRegistry abstract, with the SQL stuff in a subclass, and an in-memory version for testing use.

Anyway. WIP on https://github.com/srl295/cldr/tree/wip/cldr-15656/refactor-userreg and eventually I'll update this PR.

srl295 avatar Jan 03 '23 17:01 srl295