cldr icon indicating copy to clipboard operation
cldr copied to clipboard
verified publisher icon unicode-org

CLDR-14543 improve threading of VettingViewer

Open srl295 opened this issue 3 years ago • 6 comments

CLDR-14543

use threading for vettingviewer

  • [x] TODO: move the threading into a utility pkg, get rid of other changes here as they are in separate PRs already.

  • [ ] This PR completes the ticket.

srl295 avatar Mar 25 '22 20:03 srl295

@btangmu the commit() is https://unicode-org.atlassian.net/browse/CLDR-15488

srl295 avatar Mar 29 '22 18:03 srl295

Notice: the branch changed across the force-push!

  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/api/VoteAPIHelper.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/SurveyAjax.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/UserSettingsData.java is no longer changed in the branch
  • tools/cldr-apps/src/main/java/org/unicode/cldr/web/VettingViewerQueue.java is different
  • tools/cldr-apps/src/test/java/org/unicode/cldr/web/TestVettingViewerQueue.java is no longer changed in the branch
  • tools/cldr-code/src/main/java/org/unicode/cldr/test/CheckForCopy.java is no longer changed in the branch
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/SimpleXMLSource.java is no longer changed in the branch
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/VettingViewer.java is different
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/XMLSource.java is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook[bot] avatar Apr 06 '22 15:04 jira-pull-request-webhook[bot]

Note: still WIP, but removed the extraneous code changes.

srl295 avatar Apr 06 '22 15:04 srl295

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/main/java/org/unicode/cldr/util/ThreadPoolRunner.java is now changed in the branch
  • tools/cldr-code/src/main/java/org/unicode/cldr/util/VettingViewer.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook[bot] avatar Apr 19 '22 23:04 jira-pull-request-webhook[bot]

@btangmu still WIP (may not even work) but did split out the threading. It's potentially reusable for other in-SurveyTool parallel tasks!

ForkJoinPool is nice and convenient, but won't work.

srl295 avatar Apr 20 '22 00:04 srl295

Notice: the branch changed across the force-push!

  • tools/cldr-code/src/main/java/org/unicode/cldr/util/ThreadPoolRunner.java is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

jira-pull-request-webhook[bot] avatar Apr 20 '22 18:04 jira-pull-request-webhook[bot]