cldr icon indicating copy to clipboard operation
cldr copied to clipboard

CLDR-15319 Bump xercesImpl from 2.12.0 to 2.12.2 in /tools

Open dependabot[bot] opened this issue 3 years ago • 10 comments

Bumps xercesImpl from 2.12.0 to 2.12.2.

CLDR-15319

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language

You can disable automated security fix PRs for this repo from the Security Alerts page.

dependabot[bot] avatar Jan 27 '22 16:01 dependabot[bot]

@srl295 "This PR has undefined commits"? not sure what that means -- and is this something we should test locally before approving?

btangmu avatar Feb 04 '22 19:02 btangmu

@srl295 "This PR has undefined commits"? not sure what that means -- and is this something we should test locally before approving?

It gets an automatic test. This particular one might be good to check given the criticality of xerces.

Actually, this MIGHT have been related to the reason we had strange XML test behavior changes… perhaps this triggered our CI environment to upgrade its default XML implementation?

srl295 avatar Feb 04 '22 19:02 srl295

@srl295 i don't remember the "strange XML test behavior" -- anyway, testing locally, 2.12.2 seems fine for me so far...

we want to link this PR to https://unicode-org.atlassian.net/browse/CLDR-15319 right? should we insert "CLDR-15319" at the start of the title for this PR?

btangmu avatar Feb 09 '22 18:02 btangmu

@srl295 i don't remember the "strange XML test behavior" -- anyway, testing locally, 2.12.2 seems fine for me so far...

we want to link this PR to https://unicode-org.atlassian.net/browse/CLDR-15319 right? should we insert "CLDR-15319" at the start of the title for this PR?

yes and it needs the commit message updated also

srl295 avatar Feb 09 '22 18:02 srl295

"Commit message for 7600d13 fails validation" -- what's actually wrong with the message, and where's the validation code?

btangmu avatar Feb 09 '22 18:02 btangmu

"Commit message for 7600d13 fails validation" -- what's actually wrong with the message, and where's the validation code?

  • What's wrong with the message: it doesn't start with CLDR-____
  • where's the code: https://github.com/unicode-org/jira-github-pr-check/issues/36#issue-1056275024 (see that comment)

srl295 avatar Feb 09 '22 18:02 srl295

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@srl295 i don't remember the "strange XML test behavior" -- anyway, testing locally, 2.12.2 seems fine for me so far...

Where you had to rebase the snapshot PR to make it pass.

srl295 avatar Feb 10 '22 01:02 srl295

Where you had to rebase the snapshot PR to make it pass

Ah, the infamous "Duplicate: hi_Latn.xml"!

btangmu avatar Feb 10 '22 14:02 btangmu

Can be superseded by #1857

srl295 avatar Mar 30 '22 04:03 srl295

Notice: the branch changed across the force-push!

  • tools/pom.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

yea, superseded by #1857 and friends

srl295 avatar Oct 03 '22 15:10 srl295

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot] avatar Oct 03 '22 15:10 dependabot[bot]