Ensure clear labels for dialog actions

[enkelmedia]

I actually started an issue about this for Belle years ago but it never really got any traction. While re-working the backoffice I think it's time to raise the issue again.

Many of the labels for primary actions inside dialogs do not really make sense. Here is an example:

The user chooses a icon and then primary action is "Submit"? I think that these labels should be properly named, in this case mabe "Choose" or "Pick" would make more sense.

I'm not sure if "Submit" is some kind of default text somewhere but I think that there should not be any defaults here to force developers to user labels that make sense in the context.

Here is a list of places where we could make changes, each item in the list is also represented with details below.

Defined	Fixed	Element	Context
[x]	[ ]	Document Picker	Property Editor UI
[x]	[x]	Property Settings	Settings > Document Types
[x]	[x]	Property Settings	Settings > Media Types
[x]	[ ]	Document Types Picker	Settings > Document Type > Structure
[x]	[ ]	Select Link	Multi URL Picker (Property Editor UI)
[x]	[ ]	Tree Picker	Tree Picker
[x]	[ ]	Member Picker	Property Editor UI
[ ]	[ ]	Member Group Picker	Property Editor UI
[ ]	[ ]	User Picker	Property Editor UI
[x]	[ ]	Assign Access > Groups	Users -> Edit Users
[ ]	[x]	Assign Access > Content Start Nodes	Users -> Edit Users
[ ]	[ ]	Assign Access > Media Start Nodes	Users -> Edit Users
[x]	[ ]	TinyMce Insert/Edit Link	Content -> RTE -> Insert link
[x]	[ ]	Member -> Choose Groups	Members -> {Member}

Umb.PropertyEditorUi.DocumentPicker

• [ ] Done

The property editor allows us to open the "Select Document" dialog and will keep the state. Basically this means that we're choosing the documents no matter if the uui-ref-list is empty or has selected documents.

Current

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Select	Choose
1->*	Choose	Select	Choose

Update to

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Choose	Choose
1->*	Choose	Choose	Choose

Umb.PropertyEditorUi.TreePicker

• [ ] Done

The property editor allows us to open the Tree dialog and will keep the state. Basically this means that we're choosing the documents no matter if the uui-ref-list is empty or has selected documents.

By keeping the heading "Choose" we do not have to bather about the content type (Document or Media) being picked.

Current

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Select	Choose
1->*	Choose	Select	Choose

Update to

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Choose	Choose
1->*	Choose	Choose	Choose

Umb.PropertyEditorUi.MultiUrlPicker

• [ ] Done

The property editor allows us to open the "Link Modal" dialog to append new links. Each link can be opened to edit the link.

Current

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Add	Select Link	Submit
1->*	Add	Select Link	Submit

Update to

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Add	Add Link	Add
1->*	Add	Edit Link	Update/Save

Document Type Picker

• [ ] Done

Used when editing a document type e.g. to list/pick allowed children. In the modal it would be nice to say "Choose Document Type(s)" but it's a lot easier to just keep the headline to "Choose".

Current

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Select	Choose
1->*	Choose	Select	Choose

Update to

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Choose	Choose
1->*	Choose	Choose	Choose

Member Picker

• [ ] Done

Member Picker refers to the Property Editor UI to pick one or more Members. Similar to Document Picker it will keep the state, so "Choose" make most sense here.

Current

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Select members	Submit
1->*	Choose	Select members	Submit

Update to

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Choose Members	Choose
1->*	Choose	Choose Members	Choose

Member Group Picker

• [ ] Done

Member Picker refers to the Property Editor UI to pick one or more Member Groups. Similar to Document Picker it will keep the state, so "Choose" make most sense here.

Current

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Select member groups	Submit
1->*	Choose	Select member groups	Submit

Update to

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Choose Member Groups	Choose
1->*	Choose	Choose Member Groups	Choose

User Picker

• [ ] Done

The user picker only allows us to pick one user, it used to be a dropdown in earlier versions. When a selection has been made the button to open the selection modal is hidden. The selection can be removed which will show the modal again.

Current

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Add	Select users	Submit
1->*	n/a	n/a	n/a

Update to

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Choose User	Choose
1->*	n/a	n/a	n/a

User - Assign Access - Groups

• [ ] Done

Picker to choose groups for a User. Keep states.

Current

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Add	Select User Group	Submit
1->*	Add	Select User Group	Submit

Update to

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Choose User Groups	Choose
1->*	Choose	Choose User Groups	Choose

User - Assign Access - Media Start nodes

• [ ] Done

Picker to choose Media Start nodes for a User. Keep states.

Current

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Select	Choose
1->*	Choose	Select	Choose

Update to

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Choose Media Start nodes	Choose
1->*	Choose	Choose Media Start nodes	Choose

TinyMCE - Insert / Edit Link

• [ ] Done

This refers to the context where inserting or editing links inside the RTE.

Current

State	UUI-Ref-List Button	Modal Headline	Modal Button
Insert Link	n/a	Select Link	Submit
Edit Link	n/a	Select Link	Submit

Update to

State	UUI-Ref-List Button	Modal Headline	Modal Button
Insert Link	n/a	Insert Link	Insert
Edit Link	n/a	Edit Link	Save

Member -> Choose Groups

• [ ] Done

This refers to the "Member Groups Picker" in the context of creating/editing a Member.

Current

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Select member group	Choose
1->*	Choose	Select member group	Choose

Update to

Items selected	UUI-Ref-List Button	Modal Headline	Modal Button
0	Choose	Choose Member Groups	Choose
1->*	Choose	Choose Member Groups	Choose

Some pointers:

• /src/assets/lang/en-us.ts
• Add = general_add
• Update = general_update
• Submit = general_submit
• Select = buttons_select
• Choose = general_choose
• Done = n/a (bulk_done exists, should probably be moved)