umap icon indicating copy to clipboard operation
umap copied to clipboard

Avoid map-panning on Smartphones (using two fingers instead)

Open Dirk71 opened this issue 4 years ago • 5 comments

Embedding maps of uMap allows using the option "scrollWheelZoom" to set it on TRUE or FALSE. If it is set on FALSE it will disable the mousewheel if the cursor is located within the map. If it is set on TRUE, the mousewheel is enabled so that zooming in and out is possible.

Accordingly it should lead to the following behaviour on Smartphones. TRUE -> swiping with one finger on the map will pan the map FALSE -> swiping with one finger on the map will scroll the website instead. Using 2 fingers to swipe will pan the map. BUT THIS DOES NOT WORK AS EXPECTED.

I have reported this today (10.09.21) on GITTER channel. @yohanboniface asked me to make an issue report on Github. So, this is done now.

Dirk71 avatar Sep 10 '21 16:09 Dirk71

Hi everyone,

I would like to take care about this issue, before I start working on it I would like to make sure everyone is okay with the behavior suggested by @Dirk71 ? @yohanboniface or @davidbgk maybe ?

Thanks

fttriquet avatar Oct 11 '24 12:10 fttriquet

Hi @fttriquet yeah, I think this behaviour is more consistent and expected! Thanks for working on this! :)

yohanboniface avatar Oct 12 '24 07:10 yohanboniface

@fttriquet did you eventually get somewhere ? do you need help or more infos ? :)

yohanboniface avatar Nov 20 '24 13:11 yohanboniface

@yohanboniface I have the code but I could not get the time to write the tests yet. I'll try to do it this week or the next one.

edit: I couldn't find a test where it should go, if anyone can point me in the right direction to do so. Otherwise it is done.

fttriquet avatar Dec 05 '24 10:12 fttriquet

edit: I couldn't find a test where it should go, if anyone can point me in the right direction to do so. Otherwise it is done.

Does not seem to be supported yet by playwright: https://github.com/microsoft/playwright/issues/2903, so I'd say we cannot test this atm.

yohanboniface avatar Dec 05 '24 14:12 yohanboniface