umap icon indicating copy to clipboard operation
umap copied to clipboard

please make the Link to a map more unique

Open rocky-III opened this issue 4 years ago • 3 comments
trafficstars

i really like umap - Thank you!

Here is a feature request: It would be nice if the link to a map would bit more complex if the option "Who can view" is set to "anyone with link" .

Right now the link looks like this:

https://domain-name.de/en/map/NAME_12345

"https://domain-name.de/en/map/" is always the same "NAME" does not really matter because if you know the number _12345 and put any NAME in front of it - the link still works - so:

https://domain-name.de/en/map/NAME_12345

will link me to the same map as

https://domain-name.de/en/map/NAMExx_12345

Since the number at the end is an ongoing upcount,, raised my 1 - it is easy to view all created maps and find the link for the map your are looking for. - The link is not really a secret

If the NAME would matter or the number an the end would be a bit more complex like cryptpad https://github.com/xwiki-labs/cryptpad is doing it - the share feature by "anyone with link" would be much more usable.

THANKS

rocky-III avatar May 05 '21 10:05 rocky-III

i really think this should be talked about more. potential danger of link sharing while this issue is present is not documented anywhere, and i'm pretty sure that it will eventually catch an unaware user off-guard!

ilyamikcoder avatar Sep 05 '23 05:09 ilyamikcoder

This is indeed a concern, but it's not easy to fix with respect for history: if we change the URL form (eg. uuid instead of id), what should happen for previous URL, which are embed in HTML code else where ?

We could anyway fix if in opt in way, so new instances of uMap could use uuid from the beginning.

PR welcome :)

yohanboniface avatar Dec 28 '23 12:12 yohanboniface

This is indeed a concern, but it's not easy to fix with respect for history: if we change the URL form (eg. uuid instead of id), what should happen for previous URL, which are embed in HTML code else where ?

I believe we could catch this on the server side? Issue new IDs (UUIDs) for new maps (with a different URL scheme), and still support legacy IDs for old maps ? :thinking:

almet avatar Feb 15 '24 15:02 almet