Bump matrix-sdk dependency to 0.10.0
There is a warning that popped up during this change and I have no idea how to deal with it.
warning: elided lifetime has a name
--> src/message/mod.rs:964:29
|
957 | pub fn show_with_preview<'a>(
| -- lifetime `'a` declared here
...
964 | ) -> (Text<'a>, Option<(&dyn Protocol, u16, u16)>) {
| ^ this elided lifetime gets resolved as `'a`
|
= note: `#[warn(elided_named_lifetimes)]` on by default
Otherwise, this seems to be running fine
Comment from @bnhbvr in #iamb-dev:
i think that
history_visibility()became something returning anOptionnow, so using{:?}when rendering it in a formatted string will showNoneorSome(…), which is not super nice for the user. Might prefer something likeroom.history_visibility().map(ToString::to_string).unwrap_or_else(|| "<unknown>".to_owned())hmm that might fit in a singlemap_or_elsecall, actually
Have you tested this PR? For me it breaks the client by showing every room as "Empty Room" and leaving me unable to open them.
That's interesting. Do you have other changes in place? Is your home server different than what I'm using? Do share as many details as you can, please.
I have been using this branch as my daily driver since I submitted the PR last month, so, yes, it has been tested thoroughly. Both against synapse (matrix.org) and conduwuit.
I just tested it with matrix.org and it works. I am running synapse 1.126.0 so one version behind matrix.org.
Honestly, that should work then.
Now it works on both accounts.
Previously it was syncing a lot less on startup and starting in under one second. Maybe there is a racecondition somewhere but I'm not sure how to reproduce it. Clearing the cache seems to have no effect in either direction.
You know, I think I have been seeing longer initial syncs when starting up, but didn't really react to it because I know my home server is slow. Maybe it's not the home server at all.
I have had multisecond initial syncs on startup on every version of iamb and element-desktop I have tried. I was surprised by the short sync and thought it had something to do with sliding sync support.
It works well on an instance I'm using that runs 1.125.0
This is great, thank you for putting this together, @kenrachynski ! :pray: It looks like this PR doesn't have "allow maintainer edits" set on it, so I'm going to put @bnjbvr's suggestion for showing <unknown> instead of None in a follow-up commit.
Oh, I'll have to learn how to turn that on.
@kenrachynski From the PR screen (this page), when you're the author of the PR, it looks like this (modulo the "secrets" thing which only applies if you have actions on your repo):
