iamb icon indicating copy to clipboard operation
iamb copied to clipboard

Bump matrix-sdk dependency to 0.10.0

Open kenrachynski opened this issue 9 months ago • 9 comments

There is a warning that popped up during this change and I have no idea how to deal with it.

warning: elided lifetime has a name
   --> src/message/mod.rs:964:29
    |
957 |     pub fn show_with_preview<'a>(
    |                              -- lifetime `'a` declared here
...
964 |     ) -> (Text<'a>, Option<(&dyn Protocol, u16, u16)>) {
    |                             ^ this elided lifetime gets resolved as `'a`
    |
    = note: `#[warn(elided_named_lifetimes)]` on by default

Otherwise, this seems to be running fine

kenrachynski avatar Feb 21 '25 16:02 kenrachynski

Comment from @bnhbvr in #iamb-dev:

i think that history_visibility() became something returning an Option now, so using {:?} when rendering it in a formatted string will show None or Some(…), which is not super nice for the user. Might prefer something like room.history_visibility().map(ToString::to_string).unwrap_or_else(|| "<unknown>".to_owned())⁦ hmm that might fit in a single map_or_else call, actually  

kenrachynski avatar Feb 24 '25 17:02 kenrachynski

Have you tested this PR? For me it breaks the client by showing every room as "Empty Room" and leaving me unable to open them.

VAWVAW avatar Mar 28 '25 10:03 VAWVAW

That's interesting. Do you have other changes in place? Is your home server different than what I'm using? Do share as many details as you can, please.

I have been using this branch as my daily driver since I submitted the PR last month, so, yes, it has been tested thoroughly. Both against synapse (matrix.org) and conduwuit.

kenrachynski avatar Mar 28 '25 13:03 kenrachynski

I just tested it with matrix.org and it works. I am running synapse 1.126.0 so one version behind matrix.org.

VAWVAW avatar Mar 28 '25 19:03 VAWVAW

Honestly, that should work then.

kenrachynski avatar Mar 28 '25 19:03 kenrachynski

Now it works on both accounts.

Previously it was syncing a lot less on startup and starting in under one second. Maybe there is a racecondition somewhere but I'm not sure how to reproduce it. Clearing the cache seems to have no effect in either direction.

VAWVAW avatar Mar 28 '25 19:03 VAWVAW

You know, I think I have been seeing longer initial syncs when starting up, but didn't really react to it because I know my home server is slow. Maybe it's not the home server at all.

kenrachynski avatar Mar 28 '25 19:03 kenrachynski

I have had multisecond initial syncs on startup on every version of iamb and element-desktop I have tried. I was surprised by the short sync and thought it had something to do with sliding sync support.

VAWVAW avatar Mar 28 '25 19:03 VAWVAW

It works well on an instance I'm using that runs 1.125.0

wvffle avatar Mar 28 '25 21:03 wvffle

This is great, thank you for putting this together, @kenrachynski ! :pray: It looks like this PR doesn't have "allow maintainer edits" set on it, so I'm going to put @bnjbvr's suggestion for showing <unknown> instead of None in a follow-up commit.

ulyssa avatar May 16 '25 00:05 ulyssa

Oh, I'll have to learn how to turn that on.

kenrachynski avatar May 16 '25 01:05 kenrachynski

@kenrachynski From the PR screen (this page), when you're the author of the PR, it looks like this (modulo the "secrets" thing which only applies if you have actions on your repo):

screenshot from github docs

bnjbvr avatar May 16 '25 10:05 bnjbvr