angular-typescript icon indicating copy to clipboard operation
angular-typescript copied to clipboard

Published 20 hours ago • verified publisher icon ulfryk

Annotation Improvement

Open Romakita opened this issue 9 years ago • 3 comments

Hello ulfryk, I'd just fix a bug on my code but I had to fix some bugs on your package.json and bower.json :

  • Your package doesn't work with Angular 1.5 (or 1.5 is bugged)
  • Your version of Karma is bugged too. Change version fix them.

I didn't write more unit test because I don't like CoffeeScript :) but a thinks you can write test. The added features isn't very complicated and you know this language better than me !

I think, the TSHint configuration is a best practice, but this configuration is too strict to encourage a developer to work on your component :/ (I waist 1 hour just for fix my with TSHint ... XD )

Best regards :)

Romain

Romakita avatar Mar 07 '16 20:03 Romakita

Hello Ulfryk,

Did you see my last update ?

Romakita avatar Mar 13 '16 11:03 Romakita

@Romakita - sorry for delay, I have a lot of hard work with other things. Just give me few days ;)

ulfryk avatar Mar 15 '16 10:03 ulfryk

@Romakita - sorry for delay - just few last fixes :)

ulfryk avatar Mar 21 '16 14:03 ulfryk