react-json-view icon indicating copy to clipboard operation
react-json-view copied to clipboard

Editable JSON

Open Djboy08 opened this issue 2 years ago • 10 comments

Does this library not support editable json?

My use case is I want the end-user to be able to edit the JSON and save it later but the only thing I could see is "contentEditable". But this realistically is not what I want since that gives too much control and allows them to basically just type text.

Djboy08 avatar Nov 14 '23 22:11 Djboy08

@Djboy08 1.0 supports editing functions, 2.0 is still under study, and development is still in progress.

jaywcjlove avatar Nov 15 '23 06:11 jaywcjlove

Is the rows virtualized too? Every react json editor I come across is not virtualized, thus causing a massive data output to lag the browser.

Djboy08 avatar Nov 17 '23 23:11 Djboy08

@Djboy08 Virtualization is not supported, can an option be added to load more?

jaywcjlove avatar Nov 18 '23 13:11 jaywcjlove

This is very unfortunate, it seems all the editable react components out there just are not virtualized and its a shame.

In my case loading more could have many different ways to implement. All of which that is bad UX/UI. It seems I may just go for a monaco editor as a JSON editor as that can support a massive json, all of which is expanded without the browser dying

Djboy08 avatar Nov 18 '23 19:11 Djboy08

+1 for editing on v2.0

mikeyaa avatar Jan 28 '24 03:01 mikeyaa

+1 for editing on v2.0 🤝

brunitob avatar Mar 27 '24 23:03 brunitob

+1 for editing on v2.0

ethndotsh avatar Apr 28 '24 23:04 ethndotsh

Any timeline for this?.. Not sure if I should downgrade to 1.0.0 to use editable json or not...

shin616122 avatar Aug 13 '24 19:08 shin616122

@shin616122 I don’t have time to plan the release of version 2.0 right now, but I’ll continue to maintain it. If I’m interested, I might add the editing feature. Due to life circumstances, I’m developing some macOS applications to make a living, so I don’t have any immediate plans for this component’s editing feature as it’s more complex.

jaywcjlove avatar Aug 19 '24 04:08 jaywcjlove

@jaywcjlove Ok understood Thank you for the update!

shin616122 avatar Aug 19 '24 05:08 shin616122